| Summary: | Define default library for holds to pull report | ||
|---|---|---|---|
| Product: | Koha | Reporter: | delaye <stephane.delaye> |
| Component: | Circulation | Assignee: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
| Status: | Patch doesn't apply --- | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | adrien.saurat, fridolin.somers, gmcharlt, kyle, olli-antti.kivilahti, savitra.sirohi, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35139 | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | Bug 8074 - Define default library for holds to pull report | ||
|
Description
delaye
2012-05-11 14:18:04 UTC
Fridolyn, are you working on this? I would think it would make sense to either have the user select a library before displaying the results or filter by default on the logged-in user's branch. Then you could offer a non-JavaScript filter in the sidebar if the user wanted to resubmit with a different library selection (or to show all libraries). (In reply to Owen Leonard from comment #1) I'm not working on it yet. > you could offer a non-JavaScript filter in the sidebar Yes, good idea, with a GET form to allow the bookmarking of the URL. Created attachment 22019 [details] [review] Bug 8074 - Define default library for holds to pull report Modified the BIG SQL in pendingreserves.pl to limit the hold requests shown by the items.holdingbranch. The behaviour mimics IndependentBranches behaviour. Also added a branch picker to circ/pendingreserves.tt with an optional Show all requests-option. Changed the form from post to get so librarians can bookmark the page. Made stuff localizable! xxxxxxxxxxxxxxxxxxxxxx xxxxx TEST CASES xxxxx xxxxxxxxxxxxxxxxxxxxxx No prerequisites By default the requested list is calculated based on the current staff client branch set. (Circulation -> Set Library) xxxxxxxxxxxxxxxxxxxxxx cgi-bin/koha/circ/pendingreserves.pl xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx TEST CASE1: 1. Change branch limiter from the select-list. 2. Clear the date fields, "Start date" and "End date". 3. Press "Submit". 4. Enjoy! 5. Bookmark the url. If Date-fields are empty, defaults are calculated and url can be reused on some future day. xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx TEST CASE2: 1. Select the "Show all requests". 2. Submit. 3. Behold all holds pull requests across all branches. xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx Sponsored by the Joensuu Regional library. Sorry for stealing this bug, but it was so easy to fix and our librarian is complaining about this issue, so I needed to get it solved asap to convince our team that Koha is superior! :) (In reply to Olli-Antti Kivilahti from comment #5) > Sorry for stealing this bug Your welcome. Who provides a patch as priority ;) I think this patch has the potential to cause a bit of confusion. The holds to pull table has a branch filter already, and this adds a second branch filter. I think it would be better to utilize the existing branch filter. You will need to trigger it via javascript, either during the generation of the datatable if possible, or after the datatable has been created if not. Oops. *** Bug 6809 has been marked as a duplicate of this bug. *** Still valid? |