Bug 8074 - Define default library for holds to pull report
Summary: Define default library for holds to pull report
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Olli-Antti Kivilahti
QA Contact:
URL:
Keywords:
: 6809 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-05-11 14:18 UTC by delaye
Modified: 2023-10-23 19:58 UTC (History)
7 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8074 - Define default library for holds to pull report (5.85 KB, patch)
2013-10-16 14:45 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description delaye 2012-05-11 14:18:04 UTC
To create the list 'Holds to pull' we must enter the branch and the location at the bottom of the page.
It is possible to  store in memory the informations(branch, location) that we have chosen; We don't want enter the same informations each time we refreh the screen
Comment 1 Owen Leonard 2013-08-13 15:20:18 UTC
Fridolyn, are you working on this? I would think it would make sense to either have the user select a library before displaying the results or filter by default on the logged-in user's branch. Then you could offer a non-JavaScript filter in the sidebar if the user wanted to resubmit with a different library selection (or to show all libraries).
Comment 2 Fridolin Somers 2013-08-13 16:05:18 UTC
(In reply to Owen Leonard from comment #1)
I'm not working on it yet.
> you could offer a non-JavaScript filter in the sidebar
Yes, good idea, with a GET form to allow the bookmarking of the URL.
Comment 3 Olli-Antti Kivilahti 2013-10-16 14:45:25 UTC
Created attachment 22019 [details] [review]
Bug 8074 - Define default library for holds to pull report

Modified the BIG SQL in pendingreserves.pl to limit the hold requests shown
by the items.holdingbranch. The behaviour mimics IndependentBranches behaviour.

Also added a branch picker to circ/pendingreserves.tt with an optional
Show all requests-option.
Changed the form from post to get so librarians can bookmark the page.

Made stuff localizable!
Comment 4 Olli-Antti Kivilahti 2013-10-16 14:52:56 UTC
xxxxxxxxxxxxxxxxxxxxxx
xxxxx TEST CASES xxxxx
xxxxxxxxxxxxxxxxxxxxxx

No prerequisites

By default the requested list is calculated based on the current staff client branch set. (Circulation -> Set Library)

xxxxxxxxxxxxxxxxxxxxxx

cgi-bin/koha/circ/pendingreserves.pl

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

TEST CASE1:

1. Change branch limiter from the select-list.
2. Clear the date fields, "Start date" and "End date".
3. Press "Submit".
4. Enjoy!
5. Bookmark the url. If Date-fields are empty, defaults are calculated and url can be reused on some future day.

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

TEST CASE2:

1. Select the "Show all requests".
2. Submit.
3. Behold all holds pull requests across all branches.

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Comment 5 Olli-Antti Kivilahti 2013-10-16 14:57:05 UTC
Sponsored by the Joensuu Regional library.

Sorry for stealing this bug, but it was so easy to fix and our librarian is complaining about this issue, so I needed to get it solved asap to convince our team that Koha is superior! :)
Comment 6 Fridolin Somers 2013-10-17 13:07:52 UTC
(In reply to Olli-Antti Kivilahti from comment #5)
> Sorry for stealing this bug
Your welcome. Who provides a patch as priority ;)
Comment 7 Kyle M Hall 2013-10-25 15:45:34 UTC
I think this patch has the potential to cause a bit of confusion. The holds to pull table has a branch filter already, and this adds a second branch filter. I think it would be better to utilize the existing branch filter. You will need to trigger it via javascript, either during the generation of the datatable if possible, or after the datatable has been created if not.
Comment 8 Olli-Antti Kivilahti 2013-10-28 08:26:27 UTC
Oops.
Comment 9 Owen Leonard 2014-09-30 18:04:42 UTC
*** Bug 6809 has been marked as a duplicate of this bug. ***
Comment 10 Marc Véron 2016-10-04 16:41:29 UTC
Still valid?