Bug 35139 - Filter holds to pull on current library and add 'View all libraries' link
Summary: Filter holds to pull on current library and add 'View all libraries' link
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-23 19:57 UTC by Fridolin Somers
Modified: 2023-10-27 20:36 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 35139: Filter holds to pull on current library and add 'View all libraries' link (4.92 KB, patch)
2023-10-23 20:15 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 35139: Filter holds to pull on current library and add 'View all libraries' link (4.96 KB, patch)
2023-10-24 01:19 UTC, David Nind
Details | Diff | Splinter Review
Bug 35139: [ALTERNATE] Filter holds to pull on holding library and add 'View all libraries' link (4.30 KB, patch)
2023-10-27 20:36 UTC, Fridolin Somers
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-10-23 19:57:56 UTC
When branches are really separated, in 'Holds to pull' it would be great to filter by default on current library, like in 'Holds awaiting pickup' page.
Also for big libraries with many branches, page can be very long to load if they want to see a big time period.

I propose to change 'Holds to pull' : filter on current library and add 'View all libraries' link.
I bet it makes sens to have the same display between 'Holds to pull' and 'Holds awaiting pickup'.
If needed I'll add a system preference to manage the default behavior.
Comment 1 Fridolin Somers 2023-10-23 19:58:06 UTC
See related Bug 8074
Comment 2 Fridolin Somers 2023-10-23 20:15:07 UTC
Created attachment 157692 [details] [review]
Bug 35139: Filter holds to pull on current library and add 'View all libraries' link

When branches are really separated, in 'Holds to pull' it would be great to filter by default on current library, like in 'Holds awaiting pickup' page.
Also for big libraries with many branches, page can be very long to load if they want to see a big time period.

I propose to change 'Holds to pull' : filter on current library and add 'View all libraries' link.
I bet it makes sens to have the same display between 'Holds to pull' and 'Holds awaiting pickup'.
If needed I'll add a system preference to manage the default behavior.

Test plan :
1)
1.0) Set system preference 'IndependentBranches' = 'No'
1.1) Create some holds in different libraries
1.2) Go to 'Circulation' > 'Holds to pull'
1.3) Check you see holds of current library
1.4) Change start and end dates and submit
1.5) Click on 'View all libraries'
1.6) You see all holds + start and end dates are unchanged
1.7) Change start and end dates and submit
1.8) You still see all holds + no link 'View all libraries'
2)
2.0) Set system preference 'IndependentBranches' = 'Yes'
2.1) Go to 'Circulation' > 'Holds to pull'
2.2) Check you see holds of current library + no link 'View all libraries'
Comment 3 David Nind 2023-10-24 01:19:04 UTC
Created attachment 157716 [details] [review]
Bug 35139: Filter holds to pull on current library and add 'View all libraries' link

When branches are really separated, in 'Holds to pull' it would be great to filter by default on current library, like in 'Holds awaiting pickup' page.
Also for big libraries with many branches, page can be very long to load if they want to see a big time period.

I propose to change 'Holds to pull' : filter on current library and add 'View all libraries' link.
I bet it makes sens to have the same display between 'Holds to pull' and 'Holds awaiting pickup'.
If needed I'll add a system preference to manage the default behavior.

Test plan :
1)
1.0) Set system preference 'IndependentBranches' = 'No'
1.1) Create some holds in different libraries
1.2) Go to 'Circulation' > 'Holds to pull'
1.3) Check you see holds of current library
1.4) Change start and end dates and submit
1.5) Click on 'View all libraries'
1.6) You see all holds + start and end dates are unchanged
1.7) Change start and end dates and submit
1.8) You still see all holds + no link 'View all libraries'
2)
2.0) Set system preference 'IndependentBranches' = 'Yes'
2.1) Go to 'Circulation' > 'Holds to pull'
2.2) Check you see holds of current library + no link 'View all libraries'

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Fridolin Somers 2023-10-27 20:34:52 UTC
Ah our client ended with another version.
Filter must be on item holding library.
Exactly like the current filter at the bottom of table.

Here is the alternate patch.

I set to "in discussion" for feed backs.
Comment 5 Fridolin Somers 2023-10-27 20:36:34 UTC
Created attachment 158002 [details] [review]
Bug 35139: [ALTERNATE] Filter holds to pull on holding library and add 'View all libraries' link

Like previous patch but with impact on items.holdingbranch