When branches are really separated, in 'Holds to pull' it would be great to filter by default on current library, like in 'Holds awaiting pickup' page. Also for big libraries with many branches, page can be very long to load if they want to see a big time period. I propose to change 'Holds to pull' : filter on current library and add 'View all libraries' link. I bet it makes sens to have the same display between 'Holds to pull' and 'Holds awaiting pickup'. If needed I'll add a system preference to manage the default behavior.
See related Bug 8074
Created attachment 157692 [details] [review] Bug 35139: Filter holds to pull on current library and add 'View all libraries' link When branches are really separated, in 'Holds to pull' it would be great to filter by default on current library, like in 'Holds awaiting pickup' page. Also for big libraries with many branches, page can be very long to load if they want to see a big time period. I propose to change 'Holds to pull' : filter on current library and add 'View all libraries' link. I bet it makes sens to have the same display between 'Holds to pull' and 'Holds awaiting pickup'. If needed I'll add a system preference to manage the default behavior. Test plan : 1) 1.0) Set system preference 'IndependentBranches' = 'No' 1.1) Create some holds in different libraries 1.2) Go to 'Circulation' > 'Holds to pull' 1.3) Check you see holds of current library 1.4) Change start and end dates and submit 1.5) Click on 'View all libraries' 1.6) You see all holds + start and end dates are unchanged 1.7) Change start and end dates and submit 1.8) You still see all holds + no link 'View all libraries' 2) 2.0) Set system preference 'IndependentBranches' = 'Yes' 2.1) Go to 'Circulation' > 'Holds to pull' 2.2) Check you see holds of current library + no link 'View all libraries'
Created attachment 157716 [details] [review] Bug 35139: Filter holds to pull on current library and add 'View all libraries' link When branches are really separated, in 'Holds to pull' it would be great to filter by default on current library, like in 'Holds awaiting pickup' page. Also for big libraries with many branches, page can be very long to load if they want to see a big time period. I propose to change 'Holds to pull' : filter on current library and add 'View all libraries' link. I bet it makes sens to have the same display between 'Holds to pull' and 'Holds awaiting pickup'. If needed I'll add a system preference to manage the default behavior. Test plan : 1) 1.0) Set system preference 'IndependentBranches' = 'No' 1.1) Create some holds in different libraries 1.2) Go to 'Circulation' > 'Holds to pull' 1.3) Check you see holds of current library 1.4) Change start and end dates and submit 1.5) Click on 'View all libraries' 1.6) You see all holds + start and end dates are unchanged 1.7) Change start and end dates and submit 1.8) You still see all holds + no link 'View all libraries' 2) 2.0) Set system preference 'IndependentBranches' = 'Yes' 2.1) Go to 'Circulation' > 'Holds to pull' 2.2) Check you see holds of current library + no link 'View all libraries' Signed-off-by: David Nind <david@davidnind.com>
Ah our client ended with another version. Filter must be on item holding library. Exactly like the current filter at the bottom of table. Here is the alternate patch. I set to "in discussion" for feed backs.
Created attachment 158002 [details] [review] Bug 35139: [ALTERNATE] Filter holds to pull on holding library and add 'View all libraries' link Like previous patch but with impact on items.holdingbranch