Summary: | Add a warning if a Z39.50 search is started from the "Edit biblio record" page | ||
---|---|---|---|
Product: | Koha | Reporter: | Frédérick Capovilla <fcapovilla> |
Component: | Cataloging | Assignee: | Frédérick Capovilla <fcapovilla> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, dudzikmichal, m.de.rooy, paul.poulain, veron |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 9742 | ||
Attachments: |
Add a warning if a Z39.50 search is started from biblio edition page.
[SIGNED-OFF] Add a warning if a Z39.50 search is started from biblio edition page. |
Description
Frédérick Capovilla
2012-08-06 19:39:32 UTC
Comment hidden (obsolete)
Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) Owen had a good suggestion. Rather than adding an additional click every time someone clicks the "Z39.50 Search" button, perhaps we could change the label to something like "Replace with Z39.50"? Created attachment 12026 [details] [review] [SIGNED-OFF] Add a warning if a Z39.50 search is started from biblio edition page. Warn the user that the current biblio record might be overwritten by this action. http://bugs.koha-community.org/show_bug.cgi?id=8583 Signed-off-by: Marc Veron <veron@veron.ch> Woks as expected. I prefer this solution with an explicit warning, since several times I acidentally changed a record :-) QA comment: * tiny patch, no side effect risk * passes koha-qa.pl passed QA Question: why does the message say: "could replace" ? It "will" replace isn't it ? Patch pushed to master. More a minor bugfix than an ENH, but chris, up to you, as usual Pushed to 3.8.x will be in 3.8.6 I am not sure I like this change - actually I think it's a bit annoying for an experienced cataloger. Wouldn't it be better to change the button labelling maybe? It could say "Z39.50 overlay" or something else that makes sense in English. Also, the prompt always appears, even for a totally empty that has not been saved yet. It's totally unnecessary in this case. |