| Summary: | Add System Preference to specify Holds to Pull List Start Date | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Hold requests | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, jwagner, kyle, m.de.rooy, nengard, paul.poulain |
| Version: | 3.10 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 8585 : Add System Preference to specify Holds to Pull List Start Date
Bug 8585 : Add System Preference to specify Holds to Pull List Start Date Bug 8585 follow-up Passing syspref to template Follow up to Bug 8585: add missing word to preference [SIGNED-OFF] Follow up to Bug 8585: add missing word to preference |
||
|
Description
David Cook
2012-08-07 05:46:36 UTC
Created attachment 11516 [details] [review] Bug 8585 : Add System Preference to specify Holds to Pull List Start Date A system preference seems like overkill for this. Could we set a cookie that stored the offset so that the page would show the same offset later? Good point. I don't know much about setting cookies, but I like the idea. That said, it would mean that different staff members would have different results in different browsers rather than one consistent result across the board. In my experience, staff don't tend to think about the date ranges on the side. They either just press the submit button or accept the results that they're given (if the report is automatically generated as in Bug 8454). In terms of policy, it's easier to have staff check a set range of dates that the manager or systems person has set up with the system preference, rather than relying on staff's knowledge of how far back to check for holds. Admittedly, a cookie would solve the problem initially, but it could create a problem where someone narrows the date range and then forgets to put it back...and then staff think that there are no holds to pull, because they don't realize that the range was changed. It seems too variable :/. But that's just my opinion. (In reply to comment #2) > A system preference seems like overkill for this. Could we set a cookie that > stored the offset so that the page would show the same offset later? Created attachment 12052 [details] [review] Bug 8585 : Add System Preference to specify Holds to Pull List Start Date Currently, Koha creates a default value of 2 days ago (-2) for the start date of the Holds to pull List. This system preference allows users to specify their own default start date for this list, since users might not want to have to manually change the date all the time when they already know the set date period they want to view. The system preference value is specified as a positive integer, which is then passed as a negative integer in the handler script. This saves users from having to include a qualifer to the sys pref value. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Works as advertised. I also am for the system preference. A cookie means the librarian will have to set it every session. We could possibly have the combination of both, but I think the syspref alone is better than a cookie alone. Created attachment 12659 [details] [review] Bug 8585 follow-up Passing syspref to template Passing the syspref HoldsToPullStartDate to get the number of days displayed on the screen (instead of "two" that was hardcoded) Also s/tab/4 spaces/g QA comment: * passes koha-qa.pl * the feature work * after applying the patch, the koha/circ/pendingreserves.pl still says: "(Inclusive, default is two days ago to today, set other date ranges as needed. )". I've written a tiny follow-up that display the syspref instead of "two" passed QA (with the follow-up) Patch pushed to master Created attachment 12796 [details] [review] Follow up to Bug 8585: add missing word to preference The preference added in this bug is missing the word 'day(s)'. This patch adds it in. http://bugs.koha-community.org/show_bug.cgi?id=4118 Comment on attachment 12052 [details] [review] Bug 8585 : Add System Preference to specify Holds to Pull List Start Date pushed to maaster Comment on attachment 12659 [details] [review] Bug 8585 follow-up Passing syspref to template pushed to master string follow up needs sign off. changed from enhancement to get in to 3.10. Created attachment 12825 [details] [review] [SIGNED-OFF] Follow up to Bug 8585: add missing word to preference The preference added in this bug is missing the word 'day(s)'. This patch adds it in. http://bugs.koha-community.org/show_bug.cgi?id=4118 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Comment on attachment 12796 [details] [review] Follow up to Bug 8585: add missing word to preference >From 5d09752547e6cde4f9840c01ec54ad3a381c166f Mon Sep 17 00:00:00 2001 >From: Nicole C. Engard <nengard@bywatersolutions.com> >Date: Thu, 11 Oct 2012 21:23:48 -0400 >Subject: [PATCH] Follow up to Bug 8585: add missing word to preference > >The preference added in this bug is missing the word >'day(s)'. This patch adds it in. > >http://bugs.koha-community.org/show_bug.cgi?id=4118 >--- > .../en/modules/admin/preferences/circulation.pref | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 62938b4..6d58217 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -55,7 +55,7 @@ Circulation: > - Set the default start date for the Holds to pull list to > - pref: HoldsToPullStartDate > class: integer >- - ago. >+ - day(s) ago. > - > - pref: AllowAllMessageDeletion > choices: >-- >1.7.2.3 follow-up passes QA of course back to pushed to master & ENH, follow-up pushed I might be missing something, but where did the original patch and other follow-ups go? It looks like they've been mistakenly marked as obsolete... While circulation.pref looks good in master, it seems to me that no one will be able to apply this patch using git bz. For background, see Bug 2368 -- the original default date range was 10 years. David, After a patch is pushed it's marked obsolete to avoid clutter and make it clear which patches were pushed. Nicole Bug 9761 adds a similar preference for the end date. This does not only apply to Holds to pull but does extend to confirming future pending holds. |