Bug 8585 - Add System Preference to specify Holds to Pull List Start Date
Summary: Add System Preference to specify Holds to Pull List Start Date
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Cook
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 05:46 UTC by David Cook
Modified: 2013-12-05 20:04 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8585 : Add System Preference to specify Holds to Pull List Start Date (4.90 KB, patch)
2012-08-10 02:44 UTC, David Cook
Details | Diff | Splinter Review
Bug 8585 : Add System Preference to specify Holds to Pull List Start Date (4.84 KB, patch)
2012-09-07 15:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8585 follow-up Passing syspref to template (5.66 KB, patch)
2012-10-03 13:28 UTC, Paul Poulain
Details | Diff | Splinter Review
Follow up to Bug 8585: add missing word to preference (1.13 KB, patch)
2012-10-12 15:46 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[SIGNED-OFF] Follow up to Bug 8585: add missing word to preference (1.24 KB, patch)
2012-10-15 16:38 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2012-08-07 05:46:36 UTC
When you are on the "Holds to Pull" page in the Circulation module, the default "Start Date" in the "Refine Results" section is 2 days in the past. 

I plan to introduce a system preference that changes the number of days to however many the librarian chooses. If the system preference isn't set, the default of 2 days will continue to be used.
Comment 1 David Cook 2012-08-10 02:44:22 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-08-14 18:46:28 UTC
A system preference seems like overkill for this. Could we set a cookie that stored the offset so that the page would show the same offset later?
Comment 3 David Cook 2012-09-06 01:03:29 UTC
Good point. I don't know much about setting cookies, but I like the idea.

That said, it would mean that different staff members would have different results  in different browsers rather than one consistent result across the board. In my experience, staff don't tend to think about the date ranges on the side. They either just press the submit button or accept the results that they're given (if the report is automatically generated as in Bug 8454). 

In terms of policy, it's easier to have staff check a set range of dates that the manager or systems person has set up with the system preference, rather than relying on staff's knowledge of how far back to check for holds. Admittedly, a cookie would solve the problem initially, but it could create a problem where someone narrows the date range and then forgets to put it back...and then staff think that there are no holds to pull, because they don't realize that the range was changed. It seems too variable :/.

But that's just my opinion. 


(In reply to comment #2)
> A system preference seems like overkill for this. Could we set a cookie that
> stored the offset so that the page would show the same offset later?
Comment 4 Kyle M Hall 2012-09-07 15:22:26 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2012-09-07 15:24:06 UTC
Works as advertised. I also am for the system preference. A cookie means the librarian will have to set it every session. We could possibly have the combination of both, but I think the syspref alone is better than a cookie alone.
Comment 6 Paul Poulain 2012-10-03 13:28:57 UTC Comment hidden (obsolete)
Comment 7 Paul Poulain 2012-10-03 13:29:47 UTC
QA comment:
 * passes koha-qa.pl 
 * the feature work
 * after applying the patch, the koha/circ/pendingreserves.pl still says: "(Inclusive, default is two days ago to today, set other date ranges as needed. )". I've written a tiny follow-up that display the syspref instead of "two"

passed QA (with the follow-up)
Comment 8 Paul Poulain 2012-10-03 13:30:19 UTC
Patch pushed to master
Comment 9 Nicole C. Engard 2012-10-12 15:46:04 UTC Comment hidden (obsolete)
Comment 10 Nicole C. Engard 2012-10-12 15:47:12 UTC
Comment on attachment 12052 [details] [review]
Bug 8585 : Add System Preference to specify Holds to Pull List Start Date

pushed to maaster
Comment 11 Nicole C. Engard 2012-10-12 15:47:26 UTC
Comment on attachment 12659 [details] [review]
Bug 8585 follow-up Passing syspref to template

pushed to master
Comment 12 Nicole C. Engard 2012-10-12 15:48:07 UTC
string follow up needs sign off. changed from enhancement to get in to 3.10.
Comment 13 Owen Leonard 2012-10-15 16:38:13 UTC
Created attachment 12825 [details] [review]
[SIGNED-OFF] Follow up to Bug 8585: add missing word to preference

The preference added in this bug is missing the word
'day(s)'. This patch adds it in.

http://bugs.koha-community.org/show_bug.cgi?id=4118
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 14 Owen Leonard 2012-10-15 16:38:33 UTC
Comment on attachment 12796 [details] [review]
Follow up to Bug 8585: add missing word to preference

>From 5d09752547e6cde4f9840c01ec54ad3a381c166f Mon Sep 17 00:00:00 2001
>From: Nicole C. Engard <nengard@bywatersolutions.com>
>Date: Thu, 11 Oct 2012 21:23:48 -0400
>Subject: [PATCH] Follow up to Bug 8585: add missing word to preference
>
>The preference added in this bug is missing the word
>'day(s)'. This patch adds it in.
>
>http://bugs.koha-community.org/show_bug.cgi?id=4118
>---
> .../en/modules/admin/preferences/circulation.pref  |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index 62938b4..6d58217 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -55,7 +55,7 @@ Circulation:
>             - Set the default start date for the Holds to pull list to
>             - pref: HoldsToPullStartDate
>               class: integer
>-            - ago.
>+            - day(s) ago.
>         -
>             - pref: AllowAllMessageDeletion
>               choices:
>-- 
>1.7.2.3
Comment 15 Paul Poulain 2012-10-17 15:31:05 UTC
follow-up passes QA of course
Comment 16 Paul Poulain 2012-10-17 15:31:38 UTC
back to pushed to master & ENH, follow-up pushed
Comment 17 David Cook 2012-10-17 16:50:42 UTC
I might be missing something, but where did the original patch and other follow-ups go? It looks like they've been mistakenly marked as obsolete...

While circulation.pref looks good in master, it seems to me that no one will be able to apply this patch using git bz.
Comment 18 Jane Wagner 2012-10-17 17:15:21 UTC
For background, see Bug 2368 -- the original default date range was 10 years.
Comment 19 Nicole C. Engard 2012-10-17 17:21:11 UTC
David,

After a patch is pushed it's marked obsolete to avoid clutter and make it clear which patches were pushed.

Nicole
Comment 20 Marcel de Rooy 2013-03-07 14:34:30 UTC
Bug 9761 adds a similar preference for the end date. This does not only apply to Holds to pull but does extend to confirming future pending holds.