| Summary: | Remove hidelostitems syspref | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | System Administration | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED INVALID | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | dcook, gmcharlt, mathsabypro, mtompset, nick, tomascohen, wizzyrea |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3194 |
||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Fridolin Somers
2012-08-10 10:37:21 UTC
this syspref is still present M. Saby Does the OpacHiddenItems preference accept something like: itemslost [ > 0 ] ? If not, the library must remember to update their OpacHiddenItems preference every time they add a new value for LOST. I am not sure how hidelostitems is realized, but there are several disadvantages to using OpacHiddenItems that keep some libraries from using it (we also have a lot that do): 1) It works outside of Zebra, so there are holes in the search results and you can end up with almost empty pages if you hide a lot of things 2) Because of the holes, we have removed the numbering from the search results when OpacHiddenItems is used, to make it less obvious 3) It will need updating, as Owen points out (In reply to Katrin Fischer from comment #3) > I am not sure how hidelostitems is realized, but there are several > disadvantages to using OpacHiddenItems that keep some libraries from using > it (we also have a lot that do): > > 1) It works outside of Zebra, so there are holes in the search results and > you can end up with almost empty pages if you hide a lot of things > 2) Because of the holes, we have removed the numbering from the search > results when OpacHiddenItems is used, to make it less obvious > 3) It will need updating, as Owen points out Good point, Katrina. I'd say any move towards removing the syspref, should keep this behavior you describe from hidelostitems. It turns out there's another feature called "hidelostitems" that is defined per category code (in a bizarre way), which makes it harder to unpick the syspref "hidelostitems". In Koha/SearchEngine/Zebra/QueryBuilder.pm, it looks like "hidelostitems" used to be used with Zebra, but now I think it works outside of Zebra, and in Koha/Items.pm, "hidelostitems" is calculated in the "filter_by_visible_in_opac" function right after OpacHiddenItems anyway... Lets keep it ;) |