Created attachment 88384 [details] [review] Bug 22749: Regression tests for Koha::Item->hidden_in_opac This patch introduces regression tests for Koha::Item->hidden_in_opac to verify it is not considering the hidelostitems syspref when determining if an item should be hidden (per policy) in the OPAC. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail!
Created attachment 88385 [details] [review] Bug 22749: Make Koha::Item->hidden_in_opac respect hidelostitems This patch makes Koha::Item->hidden_in_opac take hidelostitems into account when performing the calculation. To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail because the code doesn't (yet) care about the syspref - Apply this patch - Run: k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! - Sign off :-D
Created attachment 88387 [details] [review] Bug 22749: Regression tests for Koha::Item->hidden_in_opac This patch introduces regression tests for Koha::Item->hidden_in_opac to verify it is not considering the hidelostitems syspref when determining if an item should be hidden (per policy) in the OPAC. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail! Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 88388 [details] [review] Bug 22749: Regression tests for Koha::Item->hidden_in_opac This patch introduces regression tests for Koha::Item->hidden_in_opac to verify it is not considering the hidelostitems syspref when determining if an item should be hidden (per policy) in the OPAC. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail! Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 88389 [details] [review] Bug 22749: Make Koha::Item->hidden_in_opac respect hidelostitems This patch makes Koha::Item->hidden_in_opac take hidelostitems into account when performing the calculation. To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail because the code doesn't (yet) care about the syspref - Apply this patch - Run: k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 88404 [details] [review] Bug 22749: Regression tests for Koha::Item->hidden_in_opac This patch introduces regression tests for Koha::Item->hidden_in_opac to verify it is not considering the hidelostitems syspref when determining if an item should be hidden (per policy) in the OPAC. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail! Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 88405 [details] [review] Bug 22749: Make Koha::Item->hidden_in_opac respect hidelostitems This patch makes Koha::Item->hidden_in_opac take hidelostitems into account when performing the calculation. To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail because the code doesn't (yet) care about the syspref - Apply this patch - Run: k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Depends on bug not in 18.11.x series.