Bug 8619 - Remove hidelostitems syspref
Summary: Remove hidelostitems syspref
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-10 10:37 UTC by Fridolin Somers
Modified: 2023-12-28 20:43 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2012-08-10 10:37:21 UTC
With 'OpacHiddenItems' system preference, you can reproduce what's managed by 'hidelostitems' system preference.
For example, if LOST values are 0,1,2,3 (0 meaning not lost), you can use in OpacHiddenItems :
itemslost [1, 2, 3].

So hidelostitems is now deprecated since OpacHiddenItems is more rich.
Comment 1 Mathieu Saby 2013-10-15 18:56:11 UTC
this syspref is still present

M. Saby
Comment 2 Owen Leonard 2016-03-01 17:20:39 UTC
Does the OpacHiddenItems preference accept something like:

itemslost [ > 0 ] ?

If not, the library must remember to update their OpacHiddenItems preference every time they add a new value for LOST.
Comment 3 Katrin Fischer 2019-04-28 07:51:16 UTC
I am not sure how hidelostitems is realized, but there are several disadvantages to using OpacHiddenItems that keep some libraries from using it (we also have a lot that do):

1) It works outside of Zebra, so there are holes in the search results and you can end up with almost empty pages if you hide a lot of things
2) Because of the holes, we have removed the numbering from the search results when OpacHiddenItems is used, to make it less obvious
3) It will need updating, as Owen points out
Comment 4 Tomás Cohen Arazi 2019-04-30 14:53:57 UTC
(In reply to Katrin Fischer from comment #3)
> I am not sure how hidelostitems is realized, but there are several
> disadvantages to using OpacHiddenItems that keep some libraries from using
> it (we also have a lot that do):
> 
> 1) It works outside of Zebra, so there are holes in the search results and
> you can end up with almost empty pages if you hide a lot of things
> 2) Because of the holes, we have removed the numbering from the search
> results when OpacHiddenItems is used, to make it less obvious
> 3) It will need updating, as Owen points out

Good point, Katrina. I'd say any move towards removing the syspref, should keep this behavior you describe from hidelostitems.
Comment 5 David Cook 2022-08-22 06:10:29 UTC
It turns out there's another feature called "hidelostitems" that is defined per category code (in a bizarre way), which makes it harder to unpick the syspref "hidelostitems".

In Koha/SearchEngine/Zebra/QueryBuilder.pm, it looks like "hidelostitems" used to be used with Zebra, but now I think it works outside of Zebra, and in Koha/Items.pm, "hidelostitems" is calculated in the "filter_by_visible_in_opac" function right after OpacHiddenItems anyway...
Comment 6 Fridolin Somers 2023-03-29 08:28:51 UTC
Lets keep it ;)