| Summary: | can't delete quote of the day | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, jonathan.druart, joonas.kylmala, joonas.kylmala, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | csv with quotes, for testing | ||
|
Description
Nicole C. Engard
2012-09-20 13:40:09 UTC
By the way, it does work on the import quotes screen - if I want to delete quotes from there they highlight when I click on the ID with no problem. Nicole 1) Add a new quote using "Add quote" button. 2) Try to select it for deleting (click on ID) -> the line should turn dark gray to indicate that it is selected, but it does not. 3) Try to select an other, pre existing quote --> Line turns dark gray, quote is deletable. 4) Reload page. Now, the new quote from step 1) is selectable/deletable as well. Reproduced several times ond two Koha installations (3.09.00.030 and 3.09.00.056) If this behaviour can not be fixed, documentation should state that a reload of the page is necessary to be able to delete a new quote. Marc Still valid with 3.15.00.028 I cannot reproduce this bug on 3.14.03.000 running over our production DB which contains 86 quotes. Adding the 87th quote works as expected including deleting without a page refresh. I would be interested to know if those who are experienceing this bug are adding quote number 1 to a DB containing no quotes. In my test with the sample quote data when I select a quote and click the delete button nothing happens. However, when I refresh the page the quote is no longer there. Tested with Firefox 28 on Windows using version 3.15.00.028. I'm running 3.15.00.030. 1. Drop/create database. 2. Run webinstaller, selecting sample quote data. 3. Log in to fresh install 4. Navigate to quote editor 5. Select quote #7 6. Click delete button 7. Table refreshes automatically and removes quote #7 So far so good. 8. Now the remaining quotes are unselectable. 9. Refreshing page makes remaining quote selectable again. 10. Select quote #6. 11. Click delete button 12. Table refreshes automatically and removes quote #6 13. Remaining quotes are once again unselectable So it appears that the select function gets dropped when the table is redrawn. *** Bug 9670 has been marked as a duplicate of this bug. *** At the moment there comes only the following JS error if deleting an quote: TypeError: this.oApi._fnServerParams is not a function. Line 12 in /intranet-tmpl/lib/jquery/plugins/dataTables.fnReloadAjax.js. I'm trying to figure out an fix for that and after that I'll also look into this bug. Re-tested on current master. New problem: - Have > 30 quotes to make table paging - On page 1, select a quote by clicking on Id - Go to page 2 - Select an other quote - Go to page 1, try to de-select qoute (by clicking on Id) Result: You can not de-select. - Try to select an other quote Result: You can no longer select other quotes I'm not working on this anymore so I removed myself from assigned person. Still valid for master (February 2020) Still valid on master (November 2020) Created attachment 113259 [details]
csv with quotes, for testing
(In reply to Nicole C. Engard from comment #1) > By the way, it does work on the import quotes screen - if I want to delete > quotes from there they highlight when I click on the ID with no problem. I also want to add that there is no more highlighting when trying to delete an imported quote, as there was before (see screenshot from the manual https://gitlab.com/koha-community/koha-manual/-/blob/master/source/images/tools/qotd/selectfordelete.png) It is, however, possible to delete imported quotes, you just don't see which ones you are deleting. To replicate : 1) Create a CSV with two columns first the name, then the quote (I've attached a CSV that I've done for testing purposes) 2) Go to Tools > Edit quotes for the QOTD feature 3) Click 'Import quotes' 4) Click 'Browse' and choose the CSV created earlier 5) Click on the id of a couple of quotes. Notice those quotes aren't highlighted 6) Click on the 'Delete quotes' button. Notice the pop up says 'Are you sure you want to delete quote(s) X, Y, Z?' (In reply to Caroline Cyr La Rose from comment #14) > (In reply to Nicole C. Engard from comment #1) > > By the way, it does work on the import quotes screen - if I want to delete > > quotes from there they highlight when I click on the ID with no problem. > > > I also want to add that there is no more highlighting when trying to delete > an imported quote, as there was before (see screenshot from the manual > https://gitlab.com/koha-community/koha-manual/-/blob/master/source/images/ > tools/qotd/selectfordelete.png) > > It is, however, possible to delete imported quotes, you just don't see which > ones you are deleting. > > To replicate : > > 1) Create a CSV with two columns first the name, then the quote (I've > attached a CSV that I've done for testing purposes) > 2) Go to Tools > Edit quotes for the QOTD feature > 3) Click 'Import quotes' > 4) Click 'Browse' and choose the CSV created earlier > 5) Click on the id of a couple of quotes. Notice those quotes aren't > highlighted > 6) Click on the 'Delete quotes' button. Notice the pop up says 'Are you sure > you want to delete quote(s) X, Y, Z?' Moved to its own bug report, see bug 27247. |
