Description
Vitor Fernandes
2012-11-27 12:34:38 UTC
Created attachment 13704 [details] [review] BUG 9151 - Renewal notice according to patron alert preferences Modifications on AddRenewals and SendCirculationAlert in order to send a renewal notice to the patron according to the patron checkout alert preference. Added a new notice template for renewals notices. Hi Vitor, I like the idea of a renewal notice :) Do you think you could maybe make it configurable? I can imagine not every library wants to use it and it would make it a bit easier to get it integrated in existing workflows. Ideally I would like to see it on the same level as checkout/return notices with a checkbox in the patron account, but I think a system preference would be ok for now too. The updatedatabase adds the notice template, which is good, but can you maybe provide a follow-up addings it to the sample files for the different languages? They are used for new installations. Katrin when I done the patch I had doubts about adding a system preference for controlling the renewal notice. Thinking better, it's perfectly natural to have a system preference. Today I'll submit a new patch with that modification and with the translation. Thanks, Vitor :) Created attachment 13705 [details] [review] BUG 9151 - Renewal notice according to patron alert preferences (Patch 2) Added a system preferences (RenewalSendNotice - default no) to controll the renewal notice sending. Added to installer languages the renewal notice template. Created attachment 13913 [details] [review] [SIGNED-OFF] BUG 9151 - Renewal notice according to patron alert preferences Modifications on AddRenewals and SendCirculationAlert in order to send a renewal notice to the patron according to the patron checkout alert preference. Added a new notice template for renewals notices. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 13914 [details] [review] [SIGNED-OFF] BUG 9151 - Renewal notice according to patron alert preferences (Patch 2) Added a system preferences (RenewalSendNotice - default no) to controll the renewal notice sending. Added to installer languages the renewal notice template. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 13915 [details] [review] Bug 9151 - Renewal notice according to patron alert preferences - QA Followup - Fix DB Revs & Grammar QA comment: * passes koha-qa.pl (some tabs are still here instead of 4 spaces, but they were here before) * the feature itself is nice ! * no side effect I can see passed QA Created attachment 14215 [details] [review] BUG 9151 - Renewal notice according to patron alert preferences Modifications on AddRenewals and SendCirculationAlert in order to send a renewal notice to the patron according to the patron checkout alert preference. Added a new notice template for renewals notices. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 14216 [details] [review] BUG 9151 - Renewal notice according to patron alert preferences (Patch 2) Added a system preferences (RenewalSendNotice - default no) to controll the renewal notice sending. Added to installer languages the renewal notice template. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 14217 [details] [review] Bug 9151 - Renewal notice according to patron alert preferences - QA Followup - Fix DB Revs & Grammar Created attachment 14218 [details] [review] Bug 9151 follow-up: fr-FR translated to french (Updated patch complexity) This patch has been pushed to master. *** Bug 6811 has been marked as a duplicate of this bug. *** Created attachment 14477 [details] [review] bug 9151 follow-up: fix sample notice SQL for en Fix two different errors that prevented sample notices from being loaded into a fresh English Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Follow-up patch attached that fixes installation breakage introduced by commit 97b05999. This feature broke installation in english, needs the follow tested and pushed. Created attachment 14638 [details] [review] bug 9151 follow-up: fix sample notice SQL for en Fix two different errors that prevented sample notices from being loaded into a fresh English Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Created attachment 14639 [details] [review] bug 9151 follow-up: fix sample notice SQL for en Fix two different errors that prevented sample notices from being loaded into a fresh English Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Moving this follow-up to separate bug 9413 as the original feature has already been pushed. |