Summary: | Remove useless code related to the type_only parameter | ||
---|---|---|---|
Product: | Koha | Reporter: | Rolando Isidoro <rolando.isidoro> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, chris, gmcharlt, jonathan.druart, kyle.m.hall, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 13497 | ||
Bug Blocks: | 13970 | ||
Attachments: |
Bug 9314: Remove useless code related to the type_only parameter
[SIGNED-OFF] Bug 9314: Remove useless code related to the type_only parameter [PASSED QA] Bug 9314: Remove useless code related to the type_only parameter |
Description
Rolando Isidoro
2012-12-21 15:38:40 UTC
Note that the message appears in a couple of situations: On patron edit, or on patron creation *if* you have your AddPatronLists preference set to "category_type." Looking at the code it looks like the message is intended to appear only upon patron add if AddPatronLists is set to "category_type." The warning is required because in that situation the patron category is not yet known. Therefore the interface reminds the user that default messaging preferences will be applied if none are chosen. Since I suggested to remove the broken pref AddPatronLists in bug 13497, I think the better would be to simply remove the message. Created attachment 37577 [details] [review] Bug 9314: Remove useless code related to the type_only parameter Since the pref AddPatronLists has been removed in bug 13497, the code related to type_only and category_type in memberentry.pl is useless. Test plan: Confirm you don't the information message. You can also confirm that the message was wrong and nothing was saved. Jonathan, following your comments I can confirm that the information message is no longer displayed so this bug report is deprecated. Rolando, without the path I submitted on comment 3, the message can longer appear. Created attachment 39314 [details] [review] [SIGNED-OFF] Bug 9314: Remove useless code related to the type_only parameter Since the pref AddPatronLists has been removed in bug 13497, the code related to type_only and category_type in memberentry.pl is useless. Test plan: Confirm you don't the information message. You can also confirm that the message was wrong and nothing was saved. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Dead code removed, no errors Think that bug description can be updated to commit message Created attachment 39957 [details] [review] [PASSED QA] Bug 9314: Remove useless code related to the type_only parameter Since the pref AddPatronLists has been removed in bug 13497, the code related to type_only and category_type in memberentry.pl is useless. Test plan: Confirm you don't the information message. You can also confirm that the message was wrong and nothing was saved. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Dead code removed, no errors Think that bug description can be updated to commit message Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Pushed to 3.20.x will be in 3.20.1 (shouldn't be needed for other branches) |