Summary: | Format dates in HOLD notices consistently | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Notices | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P3 | CC: | chris, jonathan.druart, koha.sekjal |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9348 - Format dates in HOLD notices consistently
[SIGNED-OFF] Bug 9348 - Format dates in HOLD notices consistently Bug 9348 - Format dates in HOLD notices consistently |
Description
Kyle M Hall (khall)
2013-01-04 13:03:45 UTC
Created attachment 14412 [details] [review] Bug 9348 - Format dates in HOLD notices consistently Right now notices for holds awaiting pickup read something like this: You have a hold available for pickup as of 2011-02-12. This hold will expire if it is not picked up before: 02/22/2011. If you no longer need this item or have any questions please contact us Both dates should be formatting based on the dateformat system preference. Test Plan: 1) Apply patch 2) Set the HOLD notice to the following: <<reserves.waitingdate>> / <<reserves.expirationdate>> 3) Place a hold for a patron 4) Enable the HOLD notice via email for that patron ( requires EnhancedMessaging ) 5) Check the item in 6) Go to the borrower's Notices tab, check the body of the new HOLD notice, it should have two dates separated by a '/' in the format set by the dateformat system preference. *** Bug 6535 has been marked as a duplicate of this bug. *** Created attachment 14429 [details] [review] [SIGNED-OFF] Bug 9348 - Format dates in HOLD notices consistently Right now notices for holds awaiting pickup read something like this: You have a hold available for pickup as of 2011-02-12. This hold will expire if it is not picked up before: 02/22/2011. If you no longer need this item or have any questions please contact us Both dates should be formatting based on the dateformat system preference. Test Plan: 1) Apply patch 2) Set the HOLD notice to the following: <<reserves.waitingdate>> / <<reserves.expirationdate>> 3) Place a hold for a patron 4) Enable the HOLD notice via email for that patron ( requires EnhancedMessaging ) 5) Check the item in 6) Go to the borrower's Notices tab, check the body of the new HOLD notice, it should have two dates separated by a '/' in the format set by the dateformat system preference. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patch works as advertised according to the test plan. QA Comment: The patch makes consistent the date formats for some notices. Marked as Passed QA. Created attachment 14565 [details] [review] Bug 9348 - Format dates in HOLD notices consistently Right now notices for holds awaiting pickup read something like this: You have a hold available for pickup as of 2011-02-12. This hold will expire if it is not picked up before: 02/22/2011. If you no longer need this item or have any questions please contact us Both dates should be formatting based on the dateformat system preference. Test Plan: 1) Apply patch 2) Set the HOLD notice to the following: <<reserves.waitingdate>> / <<reserves.expirationdate>> 3) Place a hold for a patron 4) Enable the HOLD notice via email for that patron ( requires EnhancedMessaging ) 5) Check the item in 6) Go to the borrower's Notices tab, check the body of the new HOLD notice, it should have two dates separated by a '/' in the format set by the dateformat system preference. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patch works as advertised according to the test plan. This patch has been pushed to master. Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 |