| Summary: | Replace YUI buttons on authorities editor page with Bootstrap | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/authorities/authorities.pl | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 9672 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap
[SIGNED-OFF] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap [PASSED QA] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap |
||
|
Description
Owen Leonard
2013-02-20 20:12:57 UTC
Created attachment 15574 [details] [review] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap This patch converts the "Save" button on the authorities editor page to Bootstrap, replacing YUI button code with Bootstrap markup. This patch also adds the float effect to the toolbar to match that on the MARC editor page. To test, create a new authority or load an existing one. The "Save" button should look correct and work correctly. When you scroll the page down, the toolbar should "stick" to the top of the browser window so that the "Save" button stays visible. Created attachment 15597 [details] [review] [SIGNED-OFF] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap This patch converts the "Save" button on the authorities editor page to Bootstrap, replacing YUI button code with Bootstrap markup. This patch also adds the float effect to the toolbar to match that on the MARC editor page. To test, create a new authority or load an existing one. The "Save" button should look correct and work correctly. When you scroll the page down, the toolbar should "stick" to the top of the browser window so that the "Save" button stays visible. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Button works and looks good. The toolbart sticks when scrolling, but I see a gap between the box of the save button, and the top of the window (tested with chrome, opera, firefox). (In reply to comment #2) > but I see a gap between the box of the save button, and the top of > the window (tested with chrome, opera, firefox). This issue is addressed in a change to the global CSS file. Clearing your browser cache should fix it. Created attachment 15831 [details] [review] [PASSED QA] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap This patch converts the "Save" button on the authorities editor page to Bootstrap, replacing YUI button code with Bootstrap markup. This patch also adds the float effect to the toolbar to match that on the MARC editor page. To test, create a new authority or load an existing one. The "Save" button should look correct and work correctly. When you scroll the page down, the toolbar should "stick" to the top of the browser window so that the "Save" button stays visible. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Button works and looks good. The toolbart sticks when scrolling, but I see a gap between the box of the save button, and the top of the window (tested with chrome, opera, firefox). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely. This patch has been pushed to master. |