Bug 9676

Summary: Replace YUI buttons on authorities editor page with Bootstrap
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: bgkriegel, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/authorities/authorities.pl
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 9672    
Bug Blocks:    
Attachments: Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap
[SIGNED-OFF] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap
[PASSED QA] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap

Description Owen Leonard 2013-02-20 20:12:57 UTC
The toolbar buttons on the authorities editing page (authorities.pl) are constructed using YUI. They should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-20 21:02:34 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-21 19:00:59 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2013-02-21 19:48:43 UTC
(In reply to comment #2)
> but I see a gap between the box of the save button, and the top of
> the window (tested with chrome, opera, firefox).

This issue is addressed in a change to the global CSS file. Clearing your browser cache should fix it.
Comment 4 Katrin Fischer 2013-03-02 18:11:21 UTC
Created attachment 15831 [details] [review]
[PASSED QA] Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap

This patch converts the "Save" button on the authorities editor page to
Bootstrap, replacing YUI button code with Bootstrap markup.

This patch also adds the float effect to the toolbar to match that on
the MARC editor page.

To test, create a new authority or load an existing one. The "Save"
button should look correct and work correctly. When you scroll the page
down, the toolbar should "stick" to the top of the browser window so
that the "Save" button stays visible.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Button works and looks good. The toolbart sticks when scrolling,
but I see a gap between the box of the save button, and the top of
the window (tested with chrome, opera, firefox).

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely.
Comment 5 Jared Camins-Esakov 2013-03-07 15:20:54 UTC
This patch has been pushed to master.
Comment 6 Owen Leonard 2013-10-22 22:57:55 UTC
*** Bug 8151 has been marked as a duplicate of this bug. ***