Bug 9672 - Replace YUI buttons on MARC editor page with Bootstrap
Summary: Replace YUI buttons on MARC editor page with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/cataloguing/addbiblio.pl
Keywords:
Depends on:
Blocks: 9534 9676
  Show dependency treegraph
 
Reported: 2013-02-20 13:16 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9672 - Replace YUI buttons on MARC editor page with Bootstrap (13.18 KB, patch)
2013-02-20 17:29 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9672 - Replace YUI buttons on MARC editor page with Bootstrap (13.32 KB, patch)
2013-02-21 18:22 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9672 - Replace YUI buttons on MARC editor page with Bootstrap (13.40 KB, patch)
2013-03-04 07:21 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-20 13:16:05 UTC
The toolbar buttons on the MARC editing page (addbiblio.pl) are constructed using YUI. They should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-20 17:29:27 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-21 18:22:05 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2013-02-21 18:22:59 UTC
Also tested Z39.50 button and functionality, all works.
Comment 4 Katrin Fischer 2013-03-04 07:21:14 UTC
Created attachment 15837 [details] [review]
[PASSED QA] Bug 9672 - Replace YUI buttons on MARC editor page with Bootstrap

This patch converts the buttons on the MARC editor page to Bootstrap,
replacing YUI button and menu code with Bootstrap markup.

Various workflows must be tested to confirm that functionality
remains unchanged:

- Edit existing record. Clicking the "save" button should redirect
  you to the default "view" page for that record.
- Create a new record. Clicking the "save" button should redirect you to
  the add/edit items screen.
- When creating or editing a record, test the dropdown menu attached to
  the "save" button. Each function should work correctly.
- Test using a user who does not have "edit items" permission. There
  should be no menu attached to the "save" button.
- Test using fast cataloging through circulation. A single save button
  should appear, redirecting to items.

In all cases validation should proceed before saving. Leave a required
field empty to test.

Testers should also confirm that Z39.50 button works as expected and
changing frameworks still works as usual.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: All workflows tested, with resticted and super user.
All buttons worked as expected. No errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 5 Jared Camins-Esakov 2013-03-07 15:25:29 UTC
This patch has been pushed to master.