Summary: | Changing the rows per page on a custom report fails if it has user supplied parameters | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Reports | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, fridolin.somers, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9417 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters
[SIGNED-OFF] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters [PASSED QA] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters |
Description
Kyle M Hall (khall)
2013-02-27 13:46:40 UTC
Created attachment 15724 [details] [review] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output. Test Plan: 1) Create a new report from sql as follows: SELECT * FROM borrowers WHERE surname LIKE <<Last Name>> AND firstname LIKE <<First Name>> 2) Run this report 3) Change the 'Rows per page' and click 'Update' 4) This should kick you back to the start where the report asks you for your parameters 5) Apply the patch 6) Repeat step 3, this time is should work correctly Created attachment 17851 [details] [review] [SIGNED-OFF] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output. Test Plan: 1) Create a new report from sql as follows: SELECT * FROM borrowers WHERE surname LIKE <<Last Name>> AND firstname LIKE <<First Name>> 2) Run this report 3) Change the 'Rows per page' and click 'Update' 4) This should kick you back to the start where the report asks you for your parameters 5) Apply the patch 6) Repeat step 3, this time is should work correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 17865 [details] [review] [PASSED QA] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output. Test Plan: 1) Create a new report from sql as follows: SELECT * FROM borrowers WHERE surname LIKE <<Last Name>> AND firstname LIKE <<First Name>> 2) Run this report 3) Change the 'Rows per page' and click 'Update' 4) This should kick you back to the start where the report asks you for your parameters 5) Apply the patch 6) Repeat step 3, this time is should work correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely now. All tests and QA script pass. This patch has been pushed to master and 3.12.x. Does not apply to 3.10.x please rebase if needed *** Bug 9994 has been marked as a duplicate of this bug. *** (In reply to comment #5) > Does not apply to 3.10.x please rebase if needed This bug corrects an enhancement added by bug 9417 which has only been pushed on master. So no need to create a 3.10.x rebase. @Kyle : nice job, you're like a bug hunter. |