Summary: | [3.8.X] Holds to pull showing items not available | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Hold requests | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, corinnebulac, gmcharlt, liz, m.de.rooy |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9786 - Holds to pull showing items not available
Bug 9786 - Holds to pull showing items not available Bug 9786 - Holds to pull showing items not available |
Description
Kyle M Hall (khall)
2013-03-11 13:12:10 UTC
I was unable to replicate this on master - perhaps you have something else going on? To be clear - here is what I did I had an bib with two items. I placed and filled two holds, both were marked waiting. I then placed a third hold, and ran the "holds to pull" report. The bib was not on the list. Indeed, this appears to be working in master. I discovered it in 3.8.5 I believe. I checked the version having this bug, it's 3.8.8. Created attachment 16066 [details] [review] Bug 9786 - Holds to pull showing items not available If an item is on hold and waiting for pickup, and another hold is placed on the record, a hold to pull will show in the Holds to pull report, even though there are no items that can fill that hold request. Test Plan: 1) Create a record with 1 item 2) Create 2 holds on the record 3) Fill the first hold 4) Check the Holds to pull report, it should show this record 5) Apply patch 6) Reload the Holds to pull report, it should no longer show this record Have you checked the bug is still present in 3.8.x (3.8.11 is due to be released in 9 days .. 3.8.8 is nearly 3 months old) Created attachment 16088 [details] [review] Bug 9786 - Holds to pull showing items not available If an item is on hold and waiting for pickup, and another hold is placed on the record, a hold to pull will show in the Holds to pull report, even though there are no items that can fill that hold request. Test Plan: 1) Create a record with 1 item 2) Create 2 holds on the record 3) Fill the first hold 4) Check the Holds to pull report, it should show this record 5) Apply patch 6) Reload the Holds to pull report, it should no longer show this record Yes, this bug appears to be present in 3.8.x (In reply to comment #6) > Have you checked the bug is still present in 3.8.x (3.8.11 is due to be > released in 9 days .. 3.8.8 is nearly 3 months old) I can't reproduce this bug in 3.8.x. Out of curiosity - in the DB where you see this bug, is the item perhaps in transit instead of waiting? Sandbox setup by corinne.hayet@bulac.fr with database 2 and bug 9786 on Thu Mar 21 09:44:59 2013 Something went wrong ! Applying: Bug 9786 - Holds to pull showing items not available Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging circ/pendingreserves.pl CONFLICT (content): Merge conflict in circ/pendingreserves.pl Failed to merge in the changes. Patch failed at 0001 Bug 9786 - Holds to pull showing items not available When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9786 - Holds to pull showing items not available Bug 9786 - Holds to pull showing items not available Apply? [yn] Patch left in /tmp/Bug-9786---Holds-to-pull-showing-items-not-availab-HpPDSE.pat (In reply to comment #11) > Sandbox setup by corinne.hayet@bulac.fr with database 2 and bug 9786 on Thu > Mar 21 09:44:59 2013 > Something went wrong ! > Applying: Bug 9786 - Holds to pull showing items not available > Using index info to reconstruct a base tree... > Falling back to patching base and 3-way merge... > Auto-merging circ/pendingreserves.pl > CONFLICT (content): Merge conflict in circ/pendingreserves.pl > Failed to merge in the changes. > Patch failed at 0001 Bug 9786 - Holds to pull showing items not available > When you have resolved this problem run "git am --resolved". > If you would prefer to skip this patch, instead run "git am --skip". > To restore the original branch and stop patching run "git am --abort". > Bug 9786 - Holds to pull showing items not available > > Bug 9786 - Holds to pull showing items not available > Apply? [yn] > Patch left in > /tmp/Bug-9786---Holds-to-pull-showing-items-not-availab-HpPDSE.pat This seems to be for 3.8. Created attachment 16589 [details] [review] Bug 9786 - Holds to pull showing items not available If an item is on hold and waiting for pickup, and another hold is placed on the record, a hold to pull will show in the Holds to pull report, even though there are no items that can fill that hold request. Test Plan: 1) Create a record with 1 item 2) Create 2 holds on the record 3) Fill the first hold 4) Check the Holds to pull report, it should show this record 5) Apply patch 6) Reload the Holds to pull report, it should no longer show this record Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Setting this to Passed QA, but you will just have to attract the attention of the RMaint for 3.8.X to get this pushed. I stumbled over this in 3.8.3. The line for waiting items was missing there. Seems hard to reproduce under the latest 3.8.X, but the test for found is not null will do no harm.. Pushed to 3.8.x will be in 3.8.12 |