Summary: | Missing space between 100/700 $a and $c (MARC21/XSLT) | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | MARC Bibliographic data support | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, bob, magnus, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
bug 9820: display titles in MARC21 name headings better in XSLT mode
bug 9820: display titles in MARC21 name headings better in XSLT mode bug 9820: display titles in MARC21 name headings better in XSLT mode Bug 9820 follow-up: fix a typo [PASSED QA] Bug 9820: display titles in MARC21 name headings better in XSLT mode [PASSED QA] Bug 9820 follow-up: fix a typo |
Description
Katrin Fischer
2013-03-14 21:27:30 UTC
Created attachment 16172 [details] [review] bug 9820: display titles in MARC21 name headings better in XSLT mode Prior to this patch, if a 100/700 had a $c, it would be displayed with no space between the contents of $a and $c in XSLT mode. For example, 100 1#$aSeuss,$cDr. would be displayed as SeussDr The problem was caused by the original version of the stylesheets drawing a bit too much from the MARC21 to MODS transformation. This patch also has the side effect of causing the author's dates from the $d to appear, which based on the name of the "nameABCDQ" stylesheet function was the original intent. To test: [1] In a MARC21 database, turn on XSLT display mode for staff and OPAC. [2] Create or identify a bib that has a 100 or 700 field with both a $a and a $c. [3] Before applying the patch, verify that the name is displayed in bib details and search results with the name and title squashed together. For example, "SeussDr" [3] After applying the patch, verify that the name displays in bib details and search results with a space and intervening punctuation between the name and the title. For example, "Seuss, Dr." Signed-off-by: Galen Charlton <gmc@esilibrary.com> Hi Galen, thank you for your patch :) I am a bit worried about showing the dates from $d. I suspect our libraries would not like the change and using data from the union catalog $d is probably filled in a lot of records. Could we remove this field from display again or wrap it in a span with id so it can be hidden? Setting this to "in discussion" since bug reporter and patch writer do not seem to agree on the solution. :-) (In reply to comment #3) > Setting this to "in discussion" since bug reporter and patch writer do not > seem to agree on the solution. :-) Copies of AACR2 at ten paces! No, I'm fine with a more minimal change (and besides, that makes it more likely that Jared will accept it for 3.12), and will attach a patch accordingly. Created attachment 16822 [details] [review] bug 9820: display titles in MARC21 name headings better in XSLT mode Prior to this patch, if a 100/700 had a $c, it would be displayed with no space between the contents of $a and $c in XSLT mode. For example, 100 1#$aSeuss,$cDr. would be displayed as SeussDr The problem was caused by the original version of the stylesheets drawing a bit too much from the MARC21 to MODS transformation. To test: [1] In a MARC21 database, turn on XSLT display mode for staff and OPAC. [2] Create or identify a bib that has a 100 or 700 field with both a $a and a $c. [3] Before applying the patch, verify that the name is displayed in bib details and search results with the name and title squashed together. For example, "SeussDr" [3] After applying the patch, verify that the name displays in bib details and search results with a space and intervening punctuation between the name and the title. For example, "Seuss, Dr." Signed-off-by: Galen Charlton <gmc@esilibrary.com> I get this error when I do a search in the OPAC: runtime error: file koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl element call-template The called template 'nameABCDQ' was not found. at C4/XSLT.pm line 223 Created attachment 20117 [details] [review] bug 9820: display titles in MARC21 name headings better in XSLT mode Prior to this patch, if a 100/700 had a $c, it would be displayed with no space between the contents of $a and $c in XSLT mode. For example, 100 1#$aSeuss,$cDr. would be displayed as SeussDr The problem was caused by the original version of the stylesheets drawing a bit too much from the MARC21 to MODS transformation. To test: [1] In a MARC21 database, turn on XSLT display mode for staff and OPAC. [2] Create or identify a bib that has a 100 or 700 field with both a $a and a $c. [3] Before applying the patch, verify that the name is displayed in bib details and search results with the name and title squashed together. For example, "SeussDr" [3] After applying the patch, verify that the name displays in bib details and search results with a space and intervening punctuation between the name and the title. For example, "Seuss, Dr." Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 20118 [details] [review] Bug 9820 follow-up: fix a typo Although the XSLT template was renamed to nameABCQ, one instance of the old name (nameABCDQ) was not corrected. This patch corrects that. To test: Follow test plan on previous patch Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Works for me. Created attachment 20591 [details] [review] [PASSED QA] Bug 9820: display titles in MARC21 name headings better in XSLT mode Prior to this patch, if a 100/700 had a $c, it would be displayed with no space between the contents of $a and $c in XSLT mode. For example, 100 1#$aSeuss,$cDr. would be displayed as SeussDr The problem was caused by the original version of the stylesheets drawing a bit too much from the MARC21 to MODS transformation. To test: [1] In a MARC21 database, turn on XSLT display mode for staff and OPAC. [2] Create or identify a bib that has a 100 or 700 field with both a $a and a $c. [3] Before applying the patch, verify that the name is displayed in bib details and search results with the name and title squashed together. For example, "SeussDr" [3] After applying the patch, verify that the name displays in bib details and search results with a space and intervening punctuation between the name and the title. For example, "Seuss, Dr." Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes test plan, works nicely. Created attachment 20592 [details] [review] [PASSED QA] Bug 9820 follow-up: fix a typo Although the XSLT template was renamed to nameABCQ, one instance of the old name (nameABCDQ) was not corrected. This patch corrects that. To test: Follow test plan on previous patch Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pushed to master. This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Galen! Pushed to 3.10.x, will be in 3.10.12 |