Summary: | no way to see all purchase suggestions at all | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Acquisitions | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | blocker | ||
Priority: | P5 - low | CC: | chris, kyle.m.hall, m.de.rooy |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9840 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9928 - no way to see all purchase suggestions at all
Bug 9928 - no way to see all purchase suggestions at all Bug 9928 - no way to see all purchase suggestions at all [PASSED QA] Bug 9928 - no way to see all purchase suggestions at all Bug 9928 - no way to see all purchase suggestions at all [3.10.x] |
Description
Nicole C. Engard
2013-03-26 11:19:05 UTC
I lied - no one - not even superlibrarians can get to see all suggestions anymore. It bug 9840 and bug 7300 made it so that you couldn't see them without selecting 'any' from the pull down - but now you can't select any from the pull down regardless of your permission level. Big blocker! Created attachment 16891 [details] [review] Bug 9928 - no way to see all purchase suggestions at all Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Created attachment 16892 [details] [review] Bug 9928 - no way to see all purchase suggestions at all Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as described I tested this in Koha 3.10.x and master. It's a bug in both versions and this patch fixes it. Nicole *** Bug 9840 has been marked as a duplicate of this bug. *** Created attachment 16998 [details] [review] Bug 9928 - no way to see all purchase suggestions at all Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as described Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17042 [details] [review] [PASSED QA] Bug 9928 - no way to see all purchase suggestions at all Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as described Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=9927 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes wrong behaviour. All tests and QA script pass. This patch has been pushed to master. Does not apply to 3.10.x please rebase and resubmit Created attachment 17091 [details] [review] Bug 9928 - no way to see all purchase suggestions at all [3.10.x] Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as described Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=9927 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes wrong behaviour. All tests and QA script pass. Not sure, but should this be "pushed to master" to gain Chris' attention? (In reply to comment #11) > Not sure, but should this be "pushed to master" to gain Chris' attention? I would put 3.10.X in the report name and leave it Passed QA. Pushed to master would not be the right status.. Chris will see it probably soon enough. Actually Katrin was right (she usually is), pushed to master is the queue I watch, but Jared alerted me on IRC. When its something like this, that has been pushed to master, and we have a rebased patch for a maintenance branch it's better to leave it pushed to master. Pushed to 3.10.x will be in 3.10.5 |