Bug 32614 - Highlight important comments
Summary: Highlight important comments
Status: CLOSED FIXED
Alias: None
Product: Project Infrastructure
Classification: Unclassified
Component: Bugzilla (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-12 13:40 UTC by Jonathan Druart
Modified: 2023-12-28 20:43 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Add red background to important comments (3.20 KB, patch)
2023-01-12 13:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32614: Highlight important comments (3.52 KB, patch)
2023-01-12 13:46 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32614: Highlight important comments (3.53 KB, patch)
2023-01-13 09:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32614: Highlight important comments (3.53 KB, patch)
2023-01-13 12:47 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-01-12 13:40:57 UTC
If there are too many comments it's hard to read them all, and sometimes it can be disastrous to miss an comment.

It would be very useful for QA, RM and RMaints to see easily if there is something they should not miss on a bug report.
Comment 1 Jonathan Druart 2023-01-12 13:45:01 UTC
Created attachment 145236 [details] [review]
Add red background to important comments
Comment 2 Jonathan Druart 2023-01-12 13:46:15 UTC
Created attachment 145237 [details] [review]
Bug 32614: Highlight important comments

This patch is suggesting to have an 'important' tag that could be attach
to comments, and that would highlight them.

* There is a new note at the top right
  "There are 2 important comments in this bug!"
* The 'important' tag is red 
* The comment flagged with the 'important' tag will have a red 
background for better visilibity
Comment 3 Jonathan Druart 2023-01-12 13:47:14 UTC
This is how it would look like: https://snipboard.io/UrsuAl.jpg
Comment 4 Marcel de Rooy 2023-01-13 08:54:22 UTC
From: Your Name <you@example.com>
Comment 5 Jonathan Druart 2023-01-13 09:02:51 UTC
Created attachment 145253 [details] [review]
Bug 32614: Highlight important comments

This patch is suggesting to have an 'important' tag that could be attach
to comments, and that would highlight them.

* There is a new note at the top right
  "There are 2 important comments in this bug!"
* The 'important' tag is red 
* The comment flagged with the 'important' tag will have a red 
background for better visilibity
Comment 6 Jonathan Druart 2023-01-13 12:47:52 UTC
Created attachment 145269 [details] [review]
Bug 32614: Highlight important comments

This patch is suggesting to have an 'important' tag that could be attach
to comments, and that would highlight them.

* There is a new note at the top right
  "There are 2 important comments in this bug!"
* The 'important' tag is red 
* The comment flagged with the 'important' tag will have a red 
border for better visilibity
Comment 7 Jonathan Druart 2023-01-13 12:49:37 UTC
This is how it looks like with the last patch: https://snipboard.io/KqBHWP.jpg

Replaced background-color with border-color.
Comment 8 Chris Cormack 2023-01-15 19:50:36 UTC
Patch is applied to test on bugzilla, but it doesn't seem to be doing anything

Chris
Comment 9 Jonathan Druart 2023-01-15 21:08:44 UTC
Did you remove the assets?
rm data/assets/*.js data/assets/*.css
Comment 10 Chris Cormack 2023-01-15 23:13:32 UTC
Yep its made new ones

-rw-r--r-- 1 www-data www-data 273640 Jan 15 23:12 01d1b8200ec3d6070e858c3636a8f000.js

So not quite sure whats up.
Comment 11 David Cook 2023-01-16 00:04:19 UTC
For what it's worth, it seems to be working for me?
Comment 12 Jonathan Druart 2023-01-16 07:37:34 UTC
Yes, it's working for me as well! :-)
Comment 13 Magnus Enger 2023-02-27 13:42:37 UTC
Looks good to me too. Marking as "RESOLVED FIXED". Please reopen if I missed something.