Bug 41119 - Autocompletion of basket creator does not work in acquisition-home.pl
Summary: Autocompletion of basket creator does not work in acquisition-home.pl
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Jonathan Druart
URL:
Keywords:
: 40996 (view as bug list)
Depends on: 32176
Blocks:
  Show dependency treegraph
 
Reported: 2025-10-28 11:07 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2025-11-07 17:56 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 41119: Refacto histsearch js to use it in acqui-home.tt (6.17 KB, patch)
2025-10-30 15:24 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 41119: Add missing function to acqui-home.tt (1.83 KB, patch)
2025-11-03 10:14 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 41119: Add missing function to acqui-home.tt (1.52 KB, patch)
2025-11-03 10:20 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 41119: Add missing function to acqui-home.tt (1.59 KB, patch)
2025-11-03 13:09 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 41119: Add missing function to acqui-home.tt (1.78 KB, patch)
2025-11-03 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2025-10-28 11:07:51 UTC
"Basket created by:" filter does not work in home, however it works in histsearch.pl (advanced search).

Code is missing but maybe we should group both parts of the code in a dedicated include.
Comment 1 Baptiste Wojtkowski (bwoj) 2025-10-30 15:24:27 UTC
Created attachment 188662 [details] [review]
Bug 41119: Refacto histsearch js to use it in acqui-home.tt

TEST PLAN:
DO NOT APPLY PATCH BEFORE TESTING
1 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts
2 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion is ko
3 - Apply patch
4 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts
5 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion starts
Comment 2 Baptiste Wojtkowski (bwoj) 2025-11-03 09:11:09 UTC
*** Bug 40996 has been marked as a duplicate of this bug. ***
Comment 3 Jonathan Druart 2025-11-03 09:26:29 UTC
Conflict with bug 32176
Comment 4 Baptiste Wojtkowski (bwoj) 2025-11-03 10:14:43 UTC Comment hidden (obsolete)
Comment 5 Baptiste Wojtkowski (bwoj) 2025-11-03 10:20:34 UTC
Created attachment 188921 [details] [review]
Bug 41119: Add missing function to acqui-home.tt

TEST PLAN:
DO NOT APPLY PATCH BEFORE TESTING
1 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts
2 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion is ko
3 - Apply patch
4 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts
5 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion starts
Comment 6 Andrew Fuerste-Henry 2025-11-03 13:09:31 UTC
Created attachment 188927 [details] [review]
Bug 41119: Add missing function to acqui-home.tt

TEST PLAN:
DO NOT APPLY PATCH BEFORE TESTING
1 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts
2 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion is ko
3 - Apply patch
4 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts
5 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion starts

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Comment 7 Jonathan Druart 2025-11-03 13:57:12 UTC
Created attachment 188931 [details] [review]
Bug 41119: Add missing function to acqui-home.tt

TEST PLAN:
DO NOT APPLY PATCH BEFORE TESTING
1 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts
2 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion is ko
3 - Apply patch
4 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts
5 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion starts

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>

Amended-by: Jonathan Druart
Tidy
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2025-11-03 13:57:34 UTC
heh, way easier with bug 32176 :)
Comment 9 Lucas Gass (lukeg) 2025-11-07 17:56:18 UTC
Nice work everyone!

Pushed to main for 25.11