"Basket created by:" filter does not work in home, however it works in histsearch.pl (advanced search). Code is missing but maybe we should group both parts of the code in a dedicated include.
Created attachment 188662 [details] [review] Bug 41119: Refacto histsearch js to use it in acqui-home.tt TEST PLAN: DO NOT APPLY PATCH BEFORE TESTING 1 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts 2 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion is ko 3 - Apply patch 4 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts 5 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion starts
*** Bug 40996 has been marked as a duplicate of this bug. ***
Conflict with bug 32176
Created attachment 188920 [details] [review] Bug 41119: Add missing function to acqui-home.tt TEST PLAN: DO NOT APPLY PATCH BEFORE TESTING 1 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts 2 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion is ko 3 - Apply patch 4 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts 5 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion starts
Created attachment 188921 [details] [review] Bug 41119: Add missing function to acqui-home.tt TEST PLAN: DO NOT APPLY PATCH BEFORE TESTING 1 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts 2 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion is ko 3 - Apply patch 4 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts 5 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion starts
Created attachment 188927 [details] [review] Bug 41119: Add missing function to acqui-home.tt TEST PLAN: DO NOT APPLY PATCH BEFORE TESTING 1 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts 2 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion is ko 3 - Apply patch 4 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts 5 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion starts Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Created attachment 188931 [details] [review] Bug 41119: Add missing function to acqui-home.tt TEST PLAN: DO NOT APPLY PATCH BEFORE TESTING 1 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts 2 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion is ko 3 - Apply patch 4 - Go to histsearch.pl, type "ko" in "Basket created by" -> autocompletion starts 5 - Go to acqui-home.pl, type "ko" in "Basket created by" -> autocompletion starts Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Amended-by: Jonathan Druart Tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
heh, way easier with bug 32176 :)
Nice work everyone! Pushed to main for 25.11