Bug 13164

Summary: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12829
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present
Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present
[PASSED QA] Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present

Description Tomás Cohen Arazi 2014-10-29 19:03:54 UTC
Currently, 022$z (and 011$z for UNIMARC) occurences are not shown, but the XSLT logic used introduces punctuation characters for those $z occurences.
Comment 1 Tomás Cohen Arazi 2014-10-29 19:35:50 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2014-10-30 07:48:18 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-10-31 15:32:22 UTC
Created attachment 33083 [details] [review]
[PASSED QA] Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present

Currently, 022$z (and 011$z for UNIMARC) occurences are not shown, but the XSLT
logic used introduces punctuation characters for those $z occurences.

This patch adds a check for the existence of subfield a, and only loops
on $a subfields.

To test:
- Create/have a record with 022$z (or 011$z on UNIMARC) but no 022$a (no 011$a on UNIMARC).
- Open the detail page for the record (on both OPAC and staff).
=> FAIL: the ISSN label and ';' and '.' characters incorrectly shown.
- Repeat mixing with 022$a occurences to notice the bug.
- Apply the patch, reload
=> SUCCES: ISSN label shows only on the presence of a $a, and $z are skipped.
           no matter how many ISSN fields you add.
- Sign off :-D

Regards
To+

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

Works as described on an UNIMARC DB. Mimics what's done for ISBN field.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2014-10-31 17:56:10 UTC
Patch pushed to master.