Bug 12829 - Incorrect ISBN visualization on the normal view if invalid/cancelled ISBN present
Summary: Incorrect ISBN visualization on the normal view if invalid/cancelled ISBN pre...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-26 19:05 UTC by Nicole C. Engard
Modified: 2015-06-04 23:33 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
isbn label (33.23 KB, image/png)
2014-08-26 19:05 UTC, Nicole C. Engard
Details
020$z (50.55 KB, image/png)
2014-08-26 19:05 UTC, Nicole C. Engard
Details
Bug 12829: (MARC21) properly skip 020z when rendering ISBN for normal record display (4.16 KB, patch)
2014-08-26 21:50 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 12829: (NORMARC) properly skip 020z when rendering ISBN for normal record display (4.45 KB, patch)
2014-08-26 21:51 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12829: (MARC21) properly skip 020z when rendering ISBN for normal record display (4.26 KB, patch)
2014-08-27 12:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12829: properly skip invalid ISBN when rendering for normal record display (11.33 KB, patch)
2014-10-29 18:22 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12829: properly skip invalid ISBN when rendering for normal record display (11.40 KB, patch)
2014-10-29 19:06 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[PASSED QA] Bug 12829: properly skip invalid ISBN when rendering for normal record display (11.36 KB, patch)
2014-11-05 21:15 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12829: Follow-up - fix small display issue in UNIMARC (1.23 KB, patch)
2014-11-05 21:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-08-26 19:05:13 UTC
Created attachment 31165 [details]
isbn label

The 020$z doesn't display - and shouldn't, but it does show the label for the ISBN field if there is an 020$z.  The label should only appear if there is an 020$a.
Comment 1 Nicole C. Engard 2014-08-26 19:05:29 UTC
Created attachment 31166 [details]
020$z
Comment 2 Tomás Cohen Arazi 2014-08-26 21:50:04 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2014-08-26 21:51:42 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2014-08-27 12:47:36 UTC Comment hidden (obsolete)
Comment 5 Nick Clemens (kidclamp) 2014-09-03 03:58:32 UTC
I am still getting a ";" if a field with 020$a is followed by a field with 020$z

Adding another field with 020$a does not add a doubled semicolon, and neither does a second 020$z
Comment 6 Claudio Costales 2014-10-27 21:55:43 UTC
Please see "my" Bug 11653 - For tag "020" only subfields "a" is displayed in MARC XSLT OPAC's detail template
Comment 7 Tomás Cohen Arazi 2014-10-29 18:22:30 UTC Comment hidden (obsolete)
Comment 8 Nicole C. Engard 2014-10-29 19:06:19 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2014-11-05 21:15:09 UTC
Created attachment 33273 [details] [review]
[PASSED QA] Bug 12829: properly skip invalid ISBN when rendering for normal record display

Currently, 020$z (and 010$z fr UNIMARC) occurences are not shown, but the XSLT logic
used introduces punctuation characters for those $z occurences.

This patch adds a check for the existence of subfield a, and only loops
on $a subfields.

To test:
- Create/have a record with 020$z (or 010$z on UNIMARC) but no 020$a (no 010$a on UNIMARC).
- Open the detail page for the record (on both OPAC and staff).
=> FAIL: the ISBN label and ';' and '.' characters incorrectly shown.
- Repeat mixing with 020$a occurences to notice the bug.
- Apply the patch, reload
=> SUCCES: ISBN label shows only on the presence of a $a, and $z are skipped.
           no matter how many ISBN fields you add.
- Sign off :-D

Regards
To+

http://bugs.koha-community.org/show_bug.cgi?id=12901
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2014-11-05 21:15:24 UTC
Created attachment 33274 [details] [review]
Bug 12829: Follow-up - fix small display issue in UNIMARC

UNIMARC XSLT uses <li> instead of <span>.
Comment 11 Tomás Cohen Arazi 2014-11-07 14:45:48 UTC
Patches pushed to master.