Bug 15602

Summary: Accessibility: Can't tab to add link in patron card creator add patrons popup
Product: Koha Reporter: Owen Leonard <oleonard>
Component: ToolsAssignee: natasha <tasham_8>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: brendan, chris, f.demians, gmcharlt, hector.hecaxmmx, indradg, julian.maurice, katrin.fischer, kyle.m.hall, tasham_8, testopia
Version: MainKeywords: Academy
Hardware: All   
OS: All   
URL: /cgi-bin/koha/patroncards/add_user_search.pl
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 15604, 15605    
Attachments: Bug 15602 - Accessibility: Can't tab to add link in patron card creator add patrons popup
[SIGNED-OFF]Bug 15602: Accessibility: Can't tab to add link in patron card creator add patrons popup
Bug 15602: Accessibility: Can't tab to add link in patron card creator add patrons popup
Bug 15602: Remove cursor:pointer

Description Owen Leonard 2016-01-19 16:53:54 UTC
In the patron card creator, patrons are added to a batch from a popup window which lets you search existing patrons. In this popup window it is not possible to use the tab key to highlight the "Add" link. I assume this is because, like the problem in Bug 14193, the link has no href attribute.
Comment 1 natasha 2016-01-20 03:49:52 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-01-21 15:50:34 UTC
I got this error:

Software error:

Can't call method "get_attr" without a package or object reference at /home/koha/kohaclone/patroncards/edit-batch.pl line 137.

But isn't your patch the problem here!
Comment 3 Héctor Eduardo Castro Avalos 2016-01-21 16:22:58 UTC
(In reply to Héctor Eduardo Castro Avalos from comment #2)
> I got this error:
> 
> Software error:
> 
> Can't call method "get_attr" without a package or object reference at
> /home/koha/kohaclone/patroncards/edit-batch.pl line 137.
> 
> But isn't your patch the problem here!

Ok the error is lauched when NO LIBRARY IS SET, i.e., when you're using the koha db admin user.
Comment 4 Héctor Eduardo Castro Avalos 2016-01-21 16:28:42 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-01-22 09:11:14 UTC
Created attachment 47160 [details] [review]
Bug 15602: Accessibility: Can't tab to add link in patron card creator add patrons popup

To Test -

1. Go onto Tools and then click on Patron Card Creator.
2. Click on New and then Card Batch.
3. Add a borrowernumber then add patron.
4. Search for a patron.
5. Using the tab key try to navigate onto the Add link.
6. Notice it skips Add.
7. Apply the patch and then repeat steps 1-5, notice the add link can now be accessed through using the keyboard.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2016-01-22 09:11:18 UTC
Created attachment 47161 [details] [review]
Bug 15602: Remove cursor:pointer

With the href attribute, the cusor will be displayed as a pointer.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Brendan Gallagher 2016-01-23 19:11:33 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 8 Julian Maurice 2016-01-25 11:52:47 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 9 Frédéric Demians 2016-01-25 16:29:36 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.