Bug 10698 - DeleteTransfer in C4::Circulation.pm needs return value
Summary: DeleteTransfer in C4::Circulation.pm needs return value
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: kenza
QA Contact: Testopia
URL:
Keywords:
Depends on: 10681 10692
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-08 08:36 UTC by kenza
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value (2.41 KB, patch)
2013-08-08 08:44 UTC, kenza 		Details | Diff | Splinter Review
Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value (2.61 KB, patch)
2013-08-25 22:44 UTC, Bernardo Gonzalez Kriegel 		Details | Diff | Splinter Review
Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value (2.66 KB, patch)
2013-08-27 09:49 UTC, Chris Cormack 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kenza 2013-08-08 08:36:52 UTC 

    


    


      

          
            
          


        
          Comment 1
        

        
          kenza

        

        
        

        
          2013-08-08 08:44:43 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 2
        

        
          Chris Cormack

        

        
        

        
          2013-08-08 22:35:23 UTC
        

      






I cant get this to apply, even after apply 10692

    


    


      



        
          Comment 3
        

        
          kenza

        

        
        

        
          2013-08-12 07:46:36 UTC
        

      






(In reply to Chris Cormack from comment #2)
> I cant get this to apply, even after apply 10692

Sorry i forgot to mention it, but this patch also needs to apply 10681.

    


    


      

          
            
          


        
          Comment 4
        

        
          Bernardo Gonzalez Kriegel

        

        
        

        
          2013-08-25 22:44:27 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 5
        

        
          Chris Cormack

        

        
        

        
          2013-08-27 09:49:50 UTC
        

      






Created attachment 20648 [details] [review]
Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value

This patch adds return values to DeleteTransfer:
Undef if no parameters are given
1 if a Transfer is deleted
0E0 if a wrong parameter is given

It also fixes some unit tests in t/db_dependent/Circulation_transfers.t

To test:
prove t/db_dependent/Circulation_transfers.t
t/db_dependent/Circulation_transfers.t .. ok
All tests successful.
Files=1, Tests=14, 20 wallclock secs ( 0.03 usr  0.00 sys +  0.39 cusr  0.02 csys =  0.44 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Applied 10681 and 10692 before 10698
Run prove t/db_dependent/Circulation_transfers.t without errors
No koha-qa errors on all 3 patches

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

    


    


      



        
          Comment 6
        

        
          Galen Charlton

        

        
        

        
          2013-10-09 03:59:39 UTC
        

      






Pushed to master.  Thanks, Kenza!