Bug 10681 - Inappropriate uses of finish() in C4::Circulation.pm
Summary: Inappropriate uses of finish() in C4::Circulation.pm
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: kenza
QA Contact: Testopia
URL:
Keywords:
Depends on: 10710
Blocks: 10683 10692 10698 10711
  Show dependency treegraph
 
Reported: 2013-08-05 09:20 UTC by kenza
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10681: Inappropriate uses of finish() in C4::Circulation.pm (5.70 KB, patch)
2013-08-05 09:31 UTC, kenza
Details | Diff | Splinter Review
Bug 10681: Inappropriate uses of finish() in C4::Circulation.pm (5.76 KB, patch)
2013-08-08 05:40 UTC, Chris Cormack
Details | Diff | Splinter Review
[SIGNED OFF] Bug 10681: Inappropriate uses of finish() in C4::Circulation.pm (5.86 KB, patch)
2013-08-26 21:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description kenza 2013-08-05 09:20:05 UTC

    
Comment 1 kenza 2013-08-05 09:31:27 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-08-08 05:40:20 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-08-26 21:15:14 UTC
Created attachment 20637 [details] [review]
[SIGNED OFF] Bug 10681: Inappropriate uses of finish() in C4::Circulation.pm

This patch gets rid of finish().

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Comment 4 Galen Charlton 2013-10-09 03:58:52 UTC
Pushed to master.  Thanks, Kenza!