Bug 10711 - GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result
Summary: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashre...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: kenza
QA Contact: Testopia
URL:
Keywords:
Depends on: 10681 10710
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-12 12:33 UTC by kenza
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result (1.19 KB, patch)
2013-08-12 12:43 UTC, kenza
Details | Diff | Splinter Review
Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result (1.42 KB, patch)
2013-08-25 23:01 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 10711: (follow-up) removing tabs (870 bytes, patch)
2013-08-25 23:03 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result (1.47 KB, patch)
2013-08-27 09:55 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10711: (follow-up) removing tabs (921 bytes, patch)
2013-08-27 09:56 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description kenza 2013-08-12 12:33:46 UTC

    
Comment 1 kenza 2013-08-12 12:43:30 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-08-25 23:01:43 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2013-08-25 23:03:55 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2013-08-27 09:55:38 UTC
Created attachment 20649 [details] [review]
Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result

To test :
prove t/db_dependent/Circulation_OfflineOperation.t
t/db_dependent/Circulation_OfflineOperation.t .. ok
All tests successful.
Files=1, Tests=7, 19 wallclock secs ( 0.02 usr  0.01 sys +  0.24 cusr  0.02 csys =  0.29 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: applied 10681 and 10710 before 10711
prove t/db_dependent/Circulation_OfflineOperation.t run without errors
koha-qa reports only 2 tabulations, fixed in a follow-up

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 5 Chris Cormack 2013-08-27 09:56:17 UTC
Created attachment 20650 [details] [review]
Bug 10711: (follow-up) removing tabs

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 6 Galen Charlton 2013-10-09 03:59:22 UTC
Pushed to master.  Thanks, Kenza!