Created attachment 20269 [details] [review] Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS
Created attachment 20617 [details] [review] Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: applied 10681 and 10710 before 10711 prove t/db_dependent/Circulation_OfflineOperation.t run without errors koha-qa reports only 2 tabulations, fixed in a follow-up
Created attachment 20618 [details] [review] Bug 10711: (follow-up) removing tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 20649 [details] [review] Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: applied 10681 and 10710 before 10711 prove t/db_dependent/Circulation_OfflineOperation.t run without errors koha-qa reports only 2 tabulations, fixed in a follow-up Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 20650 [details] [review] Bug 10711: (follow-up) removing tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Pushed to master. Thanks, Kenza!