This will provide a new search form for items, using MySQL as backend.
Created attachment 23674 [details] [review] Bug 11425: Add item search form in staff interface Item search is available at catalogue/itemsearch.pl (link is in catalogue/search.pl) It only uses SQL (not Zebra) * Use DataTables and server-side processing to be able to filter on individual columns after the first search is done. * Allow to export results in CSV * With Javascript disabled, search form still works (and CSV export too) There is the possibility to define "Custom search fields" in a new admin page admin/items_search_fields.pl (link is in admin/admin-home.pl) A custom item search field is defined by: * a name: its unique identifier * a label: the text displayed to the user * a MARC field/subfield: the field/subfield to query (it uses ExtractValue) * an authorised values list (optional): if defined the list is displayed in the search form New Perl dependency: Template::Plugin::JSON::Escape Test plan: 1/ Apply the patch and run updatedatabase.pl 2/ Go to advanced search (staff interface), then click on "Go to item search" 3/ Play with the search form! :) In the 3rd fieldset you can add as many fields as you want and combine them with boolean operators (AND, OR). You can use SQL jokers characters (%, _) You can output to screen (in a DataTables table) or to a CSV file. 4/ In the DataTables table, play with filters and try sorting columns. 5/ Disable Javascript (with Firefox: extensions NoScript or YesScript, or in about:config 'javascript.enabled' = false 6/ Reload the search page and do some searches on screen output. (there is no sorting or filtering features, but there is still pagination) 7/ Try again CSV output. 8/ You can re-enable Javascript. 9/ Go to Administration » Items search fields 10/ Add a new field. Example for title (in UNIMARC): Name: title Label: Title MARC field: 200 MARC subfield: a Authorised values category: None (add another field with an authorised values category to see the difference). 11/ As you are there try to update and delete some fields. 12/ Go back to items search form. You can see in the 3rd fieldset that your fields have appeared in the selects. 13/ Try searching on them. 14/ I think you're done :)
Created attachment 23675 [details] [review] Bug 11425: Add unit tests package Koha::Item::Search::Field function C4::SQLHelper::GetColumns function C4::Items::SearchItems
I'm not satisfied of the way we can access the item search page (a tiny link in advanced search page), so suggestions are very welcome! :)
Hello Do you think it will be possible to improve this enh later to use Zebra instead of SQL directly ? I suppose it would improve performance? Mathieu
Created attachment 26334 [details] [review] Bug 11425: Add item search form in staff interface Rebased on master
Created attachment 26335 [details] [review] Bug 11425: Add unit tests Rebased on master
test on sandbox and then : Software error: Template process failed: plugin error - JSON.Escape: plugin not found at /home/koha/src/C4/Templates.pm line 132. For help, please send mail to the webmaster (webmaster@matrice-koha36-sandbox), giving this error message and the time and date of the error.
(In reply to Pascale Nalon from comment #7) > test on sandbox and then : > Software error: > > Template process failed: plugin error - JSON.Escape: plugin not found I notice also that the bug number in updatedatabase.pl is missing: print "Upgrade to $DBversion done (Bug XXXXX: Add items_search_fields table)\n";
Created attachment 26555 [details] [review] Bug 11425: Add item search form in staff interface Rebased on master Fixed bug number in updatedatabase.pl
Created attachment 26556 [details] [review] Bug 11425: Add unit tests Rebased on master
Created attachment 26557 [details] [review] Bug 11425: Add filter on items.notforloan column and display the 'Processing ...' box when datatables is loading new data.
(In reply to Pascale Nalon from comment #7) > test on sandbox and then : > Software error: > > Template process failed: plugin error - JSON.Escape: plugin not found at > /home/koha/src/C4/Templates.pm line 132. > For help, please send mail to the webmaster > (webmaster@matrice-koha36-sandbox), giving this error message and the time > and date of the error. This development has additional dependencies which are not installed on sandboxes. Please tell me which sandbox you are using and I will install the required dependencies on it.
Created attachment 27111 [details] [review] [SIGNED-OFF] Bug 11425: Add item search form in staff interface Item search is available at catalogue/itemsearch.pl (link is in catalogue/search.pl) It only uses SQL (not Zebra) * Use DataTables and server-side processing to be able to filter on individual columns after the first search is done. * Allow to export results in CSV * With Javascript disabled, search form still works (and CSV export too) There is the possibility to define "Custom search fields" in a new admin page admin/items_search_fields.pl (link is in admin/admin-home.pl) A custom item search field is defined by: * a name: its unique identifier * a label: the text displayed to the user * a MARC field/subfield: the field/subfield to query (it uses ExtractValue) * an authorised values list (optional): if defined the list is displayed in the search form New Perl dependency: Template::Plugin::JSON::Escape Test plan: 1/ Apply the patch and run updatedatabase.pl 2/ Go to advanced search (staff interface), then click on "Go to item search" 3/ Play with the search form! :) In the 3rd fieldset you can add as many fields as you want and combine them with boolean operators (AND, OR). You can use SQL jokers characters (%, _) You can output to screen (in a DataTables table) or to a CSV file. 4/ In the DataTables table, play with filters and try sorting columns. 5/ Disable Javascript (with Firefox: extensions NoScript or YesScript, or in about:config 'javascript.enabled' = false 6/ Reload the search page and do some searches on screen output. (there is no sorting or filtering features, but there is still pagination) 7/ Try again CSV output. 8/ You can re-enable Javascript. 9/ Go to Administration > Items search fields 10/ Add a new field. Example for title (in UNIMARC): Name: title Label: Title MARC field: 200 MARC subfield: a Authorised values category: None (add another field with an authorised values category to see the difference). 11/ As you are there try to update and delete some fields. 12/ Go back to items search form. You can see in the 3rd fieldset that your fields have appeared in the selects. 13/ Try searching on them. 14/ I think you're done :) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. Good new option. No koha-qa errors
Created attachment 27112 [details] [review] [SIGNED-OFF] Bug 11425: Add unit tests package Koha::Item::Search::Field function C4::SQLHelper::GetColumns function C4::Items::SearchItems Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tests run without error
Created attachment 27113 [details] [review] [SIGNED-OFF] Bug 11425: Add filter on items.notforloan column and display the 'Processing ...' box when datatables is loading new data. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Nice box
(In reply to Julian Maurice from comment #3) > I'm not satisfied of the way we can access the item search page (a tiny link > in advanced search page), so suggestions are very welcome! :) Perhaps with two tabs, left for Advanced search, right for item search :) Only annoying thing (may be inevitable) is loosing browser history, a back on item search results lands you on advanced search, click on a record or item view/edit, press back and lands on item search, loosing results Good work!
I really like the idea of this new feature, but I am a bit worried about adding new code to SQLHelper now that we have DBIX and in ligth of bug 11385.
Created attachment 27162 [details] [review] Bug 11425: Get column names using DBIX
Please change "joker" to "wildcard". It may be good to also document that % matches any number of chracters and that _ matches only a single character. Another issue is that it's a bit confusing that when I ran a search, the first then I say was my search form again! I would suggest that when there are results, change the form title from "Item search" to "Item search parameters" or something like that, and make it a link that will expand and collapse the form using jquery.
On more thing, please change the "modify" links in the results to "edit" so they match up with the rest of Koha.
Created attachment 27975 [details] [review] Bug 11425: Add item search form in staff interface Rebased on master
Created attachment 27976 [details] [review] Bug 11425: Add unit tests Rebased on master
Created attachment 27977 [details] [review] Bug 11425: Add filter on items.notforloan column Rebased on master
Created attachment 27978 [details] [review] Bug 11425: Get column names using DBIX Rebased on master
Created attachment 27979 [details] [review] Bug 11425: QA fixes - Reword 'joker' to 'wildcard' - Explain what wildcards do - Reword 'Modify' to 'Edit' Also fix jQuery plugin columnFilter path
> Another issue is that it's a bit confusing that when I ran a search, the > first then I say was my search form again! I would suggest that when there > are results, change the form title from "Item search" to "Item search > parameters" or something like that, and make it a link that will expand and > collapse the form using jquery. This is already the case, search form is automatically collapsed after submit. But the bad path of columnFilter plugin was certainly causing a JS error, causing the following javascript code to not be executed.
Created attachment 29965 [details] [review] Bug 11425: Display location label instead of code
The last patch needs a signoff.
Created attachment 30195 [details] [review] Bug 11425: Add item search form in staff interface Item search is available at catalogue/itemsearch.pl (link is in catalogue/search.pl) It only uses SQL (not Zebra) * Use DataTables and server-side processing to be able to filter on individual columns after the first search is done. * Allow to export results in CSV * With Javascript disabled, search form still works (and CSV export too) There is the possibility to define "Custom search fields" in a new admin page admin/items_search_fields.pl (link is in admin/admin-home.pl) A custom item search field is defined by: * a name: its unique identifier * a label: the text displayed to the user * a MARC field/subfield: the field/subfield to query (it uses ExtractValue) * an authorised values list (optional): if defined the list is displayed in the search form New Perl dependency: Template::Plugin::JSON::Escape Test plan: 1/ Apply the patch and run updatedatabase.pl 2/ Go to advanced search (staff interface), then click on "Go to item search" 3/ Play with the search form! :) In the 3rd fieldset you can add as many fields as you want and combine them with boolean operators (AND, OR). You can use SQL jokers characters (%, _) You can output to screen (in a DataTables table) or to a CSV file. 4/ In the DataTables table, play with filters and try sorting columns. 5/ Disable Javascript (with Firefox: extensions NoScript or YesScript, or in about:config 'javascript.enabled' = false 6/ Reload the search page and do some searches on screen output. (there is no sorting or filtering features, but there is still pagination) 7/ Try again CSV output. 8/ You can re-enable Javascript. 9/ Go to Administration > Items search fields 10/ Add a new field. Example for title (in UNIMARC): Name: title Label: Title MARC field: 200 MARC subfield: a Authorised values category: None (add another field with an authorised values category to see the difference). 11/ As you are there try to update and delete some fields. 12/ Go back to items search form. You can see in the 3rd fieldset that your fields have appeared in the selects. 13/ Try searching on them. 14/ I think you're done :) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. Good new option. No koha-qa errors
Created attachment 30196 [details] [review] Bug 11425: Add unit tests package Koha::Item::Search::Field function C4::SQLHelper::GetColumns function C4::Items::SearchItems Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tests run without error
Created attachment 30197 [details] [review] Bug 11425: Add filter on items.notforloan column and display the 'Processing ...' box when datatables is loading new data. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Nice box
Created attachment 30198 [details] [review] Bug 11425: Get column names using DBIX Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 30199 [details] [review] Bug 11425: QA fixes - Reword 'joker' to 'wildcard' - Explain what wildcards do - Reword 'Modify' to 'Edit' Also fix jQuery plugin columnFilter path Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 30200 [details] [review] Bug 11425: Display location label instead of code Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Minor conflicts solved Last three patches signed No koha-qa errors.
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/Items.pm Auto-merging C4/Installer/PerlDependencies.pm CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm
Created attachment 32304 [details] [review] Bug 11425: Add item search form in staff interface Item search is available at catalogue/itemsearch.pl (link is in catalogue/search.pl) It only uses SQL (not Zebra) * Use DataTables and server-side processing to be able to filter on individual columns after the first search is done. * Allow to export results in CSV * With Javascript disabled, search form still works (and CSV export too) There is the possibility to define "Custom search fields" in a new admin page admin/items_search_fields.pl (link is in admin/admin-home.pl) A custom item search field is defined by: * a name: its unique identifier * a label: the text displayed to the user * a MARC field/subfield: the field/subfield to query (it uses ExtractValue) * an authorised values list (optional): if defined the list is displayed in the search form New Perl dependency: Template::Plugin::JSON::Escape Test plan: 1/ Apply the patch and run updatedatabase.pl 2/ Go to advanced search (staff interface), then click on "Go to item search" 3/ Play with the search form! :) In the 3rd fieldset you can add as many fields as you want and combine them with boolean operators (AND, OR). You can use SQL jokers characters (%, _) You can output to screen (in a DataTables table) or to a CSV file. 4/ In the DataTables table, play with filters and try sorting columns. 5/ Disable Javascript (with Firefox: extensions NoScript or YesScript, or in about:config 'javascript.enabled' = false 6/ Reload the search page and do some searches on screen output. (there is no sorting or filtering features, but there is still pagination) 7/ Try again CSV output. 8/ You can re-enable Javascript. 9/ Go to Administration > Items search fields 10/ Add a new field. Example for title (in UNIMARC): Name: title Label: Title MARC field: 200 MARC subfield: a Authorised values category: None (add another field with an authorised values category to see the difference). 11/ As you are there try to update and delete some fields. 12/ Go back to items search form. You can see in the 3rd fieldset that your fields have appeared in the selects. 13/ Try searching on them. 14/ I think you're done :) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. Good new option. No koha-qa errors
Created attachment 32305 [details] [review] Bug 11425: Add unit tests package Koha::Item::Search::Field function C4::SQLHelper::GetColumns function C4::Items::SearchItems Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tests run without error
Created attachment 32306 [details] [review] Bug 11425: Add filter on items.notforloan column and display the 'Processing ...' box when datatables is loading new data. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Nice box
Created attachment 32307 [details] [review] Bug 11425: Get column names using DBIX Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 32308 [details] [review] Bug 11425: QA fixes - Reword 'joker' to 'wildcard' - Explain what wildcards do - Reword 'Modify' to 'Edit' Also fix jQuery plugin columnFilter path Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 32309 [details] [review] Bug 11425: Display location label instead of code Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Minor conflicts solved Last three patches signed No koha-qa errors.
It looks like there is no package for Template::Plugin::JSON::Escape in Ubuntu <= 12.04.
Created attachment 32669 [details] [review] [PASSED QA] Bug 11425: Add item search form in staff interface Item search is available at catalogue/itemsearch.pl (link is in catalogue/search.pl) It only uses SQL (not Zebra) * Use DataTables and server-side processing to be able to filter on individual columns after the first search is done. * Allow to export results in CSV * With Javascript disabled, search form still works (and CSV export too) There is the possibility to define "Custom search fields" in a new admin page admin/items_search_fields.pl (link is in admin/admin-home.pl) A custom item search field is defined by: * a name: its unique identifier * a label: the text displayed to the user * a MARC field/subfield: the field/subfield to query (it uses ExtractValue) * an authorised values list (optional): if defined the list is displayed in the search form New Perl dependency: Template::Plugin::JSON::Escape Test plan: 1/ Apply the patch and run updatedatabase.pl 2/ Go to advanced search (staff interface), then click on "Go to item search" 3/ Play with the search form! :) In the 3rd fieldset you can add as many fields as you want and combine them with boolean operators (AND, OR). You can use SQL jokers characters (%, _) You can output to screen (in a DataTables table) or to a CSV file. 4/ In the DataTables table, play with filters and try sorting columns. 5/ Disable Javascript (with Firefox: extensions NoScript or YesScript, or in about:config 'javascript.enabled' = false 6/ Reload the search page and do some searches on screen output. (there is no sorting or filtering features, but there is still pagination) 7/ Try again CSV output. 8/ You can re-enable Javascript. 9/ Go to Administration > Items search fields 10/ Add a new field. Example for title (in UNIMARC): Name: title Label: Title MARC field: 200 MARC subfield: a Authorised values category: None (add another field with an authorised values category to see the difference). 11/ As you are there try to update and delete some fields. 12/ Go back to items search form. You can see in the 3rd fieldset that your fields have appeared in the selects. 13/ Try searching on them. 14/ I think you're done :) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. Good new option. No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 32670 [details] [review] [PASSED QA] Bug 11425: Add unit tests package Koha::Item::Search::Field function C4::SQLHelper::GetColumns function C4::Items::SearchItems Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tests run without error Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 32671 [details] [review] [PASSED QA] Bug 11425: Add filter on items.notforloan column and display the 'Processing ...' box when datatables is loading new data. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Nice box Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 32672 [details] [review] [PASSED QA] Bug 11425: Get column names using DBIX Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 32673 [details] [review] [PASSED QA] Bug 11425: QA fixes - Reword 'joker' to 'wildcard' - Explain what wildcards do - Reword 'Modify' to 'Edit' Also fix jQuery plugin columnFilter path Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 32674 [details] [review] [PASSED QA] Bug 11425: Display location label instead of code Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Minor conflicts solved Last three patches signed No koha-qa errors. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 32675 [details] [review] [PASSED QA] Bug 11425 [QA Followup] - Fix number of unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA note: it would be nice if the item's holding branch was part of the search form, but I see this is a further enhancement and no reason to fail qa.
Adding Robin, because of comment #42: > It looks like there is no package for Template::Plugin::JSON::Escape in > Ubuntu <= 12.04.
(In reply to Katrin Fischer from comment #51) > Adding Robin, because of comment #42: > > It looks like there is no package for Template::Plugin::JSON::Escape in > > Ubuntu <= 12.04. It's in wheezy and above: https://packages.debian.org/search?keywords=libtemplate-plugin-json-escape-perl&searchon=names&suite=all§ion=all That'll make it easy to backport...
(In reply to Robin Sheat from comment #52) > It's in wheezy and above: > > https://packages.debian.org/search?keywords=libtemplate-plugin-json-escape- > perl&searchon=names&suite=all§ion=all > > That'll make it easy to backport... Famous last words, but it's in there now.
I notice this feature will happily allow you to submit an empty search which returns all items. Is that okay?
Created attachment 32918 [details] [review] Bug 11425 [Template follow-up] Search form for items This template followup makes several changes to markup and text: - Replace "Bibliographic reference" with "Title" - Replace "Callnumber" with "Call number" - Replace "Home branch" with "Home library" - Replace "Holding branch" with "Current location" - Replace "Location" with "Shelving location" - Replace "Issues" with "Checkouts" - Replace "Indifferent" with "Ignore" - Replace "&" with "&" where necessary - Correct page title and breadcrumbs - Remove label "for" attribute from labels which do not directly target a form field - Correct label "for" attribute on labels which should target a form field - Correct date format hint This patch also makes one change to the way the page display works: The search results section is now in a separate div which uses a different grid rule, allowing it to take up the full width of the screen. To keep the page headers from looking weird I've changed the markup so that each section has its own header. To test, perform a variety of searches and confirm that the output in both Screen and CSV views looks correct. Confirm that search results which are output to the screen are formatted nicely and that the "edit search" links work correctly to show the search form. Submitting a new search after editing a search should hide the form and redisplay the search results table.
I got a merge error for installer/data/mysql/updatedatabase.pl After resolving it I got errors about missing curly brackets et EOF while updating the database. Seems to be something with the quotes after line 8892 $DBversion = "3.17.00.XXX";
(In reply to Marc Véron from comment #56) > After resolving it I got errors about missing curly brackets et EOF while > updating the database. I too had to fix merge problems with updatedatbase.pl but I didn't get any errors. Can you please double-check your changes?
Ah, found :-)
Created attachment 32926 [details] [review] Bug 11425 [Template follow-up] Search form for items This template followup makes several changes to markup and text: - Replace "Bibliographic reference" with "Title" - Replace "Callnumber" with "Call number" - Replace "Home branch" with "Home library" - Replace "Holding branch" with "Current location" - Replace "Location" with "Shelving location" - Replace "Issues" with "Checkouts" - Replace "Indifferent" with "Ignore" - Replace "&" with "&" where necessary - Correct page title and breadcrumbs - Remove label "for" attribute from labels which do not directly target a form field - Correct label "for" attribute on labels which should target a form field - Correct date format hint This patch also makes one change to the way the page display works: The search results section is now in a separate div which uses a different grid rule, allowing it to take up the full width of the screen. To keep the page headers from looking weird I've changed the markup so that each section has its own header. To test, perform a variety of searches and confirm that the output in both Screen and CSV views looks correct. Confirm that search results which are output to the screen are formatted nicely and that the "edit search" links work correctly to show the search form. Submitting a new search after editing a search should hide the form and redisplay the search results table. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
The follow up is looking good. Thinking about terminology, I think we should rename stock number to be inventory number to match how it's called in the frameworks. But this shouldn't be a blocker here.
Created attachment 32947 [details] [review] Bug 11425 [Template follow-up] Search form for items This template followup makes several changes to markup and text: - Replace "Bibliographic reference" with "Title" - Replace "Callnumber" with "Call number" - Replace "Home branch" with "Home library" - Replace "Holding branch" with "Current location" - Replace "Location" with "Shelving location" - Replace "Issues" with "Checkouts" - Replace "Indifferent" with "Ignore" - Replace "&" with "&" where necessary - Correct page title and breadcrumbs - Remove label "for" attribute from labels which do not directly target a form field - Correct label "for" attribute on labels which should target a form field - Correct date format hint This patch also makes one change to the way the page display works: The search results section is now in a separate div which uses a different grid rule, allowing it to take up the full width of the screen. To keep the page headers from looking weird I've changed the markup so that each section has its own header. To test, perform a variety of searches and confirm that the output in both Screen and CSV views looks correct. Confirm that search results which are output to the screen are formatted nicely and that the "edit search" links work correctly to show the search form. Submitting a new search after editing a search should hide the form and redisplay the search results table. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 32948 [details] [review] [PASSED QA] Bug 11425 [Template follow-up] Search form for items This template followup makes several changes to markup and text: - Replace "Bibliographic reference" with "Title" - Replace "Callnumber" with "Call number" - Replace "Home branch" with "Home library" - Replace "Holding branch" with "Current location" - Replace "Location" with "Shelving location" - Replace "Issues" with "Checkouts" - Replace "Indifferent" with "Ignore" - Replace "&" with "&" where necessary - Correct page title and breadcrumbs - Remove label "for" attribute from labels which do not directly target a form field - Correct label "for" attribute on labels which should target a form field - Correct date format hint This patch also makes one change to the way the page display works: The search results section is now in a separate div which uses a different grid rule, allowing it to take up the full width of the screen. To keep the page headers from looking weird I've changed the markup so that each section has its own header. To test, perform a variety of searches and confirm that the output in both Screen and CSV views looks correct. Confirm that search results which are output to the screen are formatted nicely and that the "edit search" links work correctly to show the search form. Submitting a new search after editing a search should hide the form and redisplay the search results table. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, improves display.
Hm and current location maybe current library?
Patches pushed to master. Thanks Julian!
I have just updated 2 sandboxes and got: DBD::mysql::db do failed: Can't create table 'test16.items_search_fields' (errno: 150) at installer/data/mysql/updatedatabase.pl line 8991. Upgrade to 3.17.00.046 done (Bug 11425: Add items_search_fields table)
I ran an update from 3.16.2 on my development installation at work on Friday and had no errors. It looked quite good - could it be the database already had the change somehow?
No, the table does not exist yet. Actually I got the error on both sandboxes used for bug 11944. It comes from the FK, I am able to create the table if I remove the constraint.
Ok, got it! It comes from the different charset collate introduced by 11944. Sorry for the noise.
(In reply to Jonathan Druart from comment #68) > Ok, got it! > It comes from the different charset collate introduced by 11944. > Sorry for the noise. I should have cared more about this problem, see bug 13577 for a fix.
This introduced a regression on checking for duplicate, see bug 8684 for a fix.
The use of the CGI TT plugin floods logs with: itemsearch.pl: CGI::param called in list context from package Template::Document line 118, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl Julian, can you check how we can fix that?
See bug 18633