In some cases it would be nice if it was possible to duplicate an order easily (serials, databases, etc.).
The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>.
Do we want to create a new basket by duplicating order lines from only one basket, or from several baskets?
We can imagine 1. You are on the vendor view (/acqui/supplier.pl?booksellerid=X), click on "New > Duplicate a basket", then you select the order lines you want to duplicate. or 2. You are on the basket view (/acqui/basket.pl?basketno=X), click "Add to basket > From existing order lines" Then you get a form/table like the one we have to search order lines (acqui/histsearch.pl), then you select the ones you want to duplicate. In both case we will have another view to change the values you want to modify. We could also: 3. You are viewing an existing basket, you click on a "duplicate" link next to one of the orders. Then you select another basket in a list. That sounds less flexible, but could be implemented later
At BULAC, we have a preference for the first option : "1. You are on the vendor view (/acqui/supplier.pl?booksellerid=X), click on "New > Duplicate a basket", then you select the order lines you want to duplicate" ! Tanks a lot !
Created attachment 77314 [details] [review] Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file.
Created attachment 77315 [details] [review] Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code.
Created attachment 77316 [details] [review] Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers
Created attachment 77317 [details] [review] Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate!
Created attachment 77318 [details] [review] Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving?
This new feature is ready to be tested! I have finally change my mind about how this feature is implemented, I hope it will make sense to you too. As we already have a "add to basket" popup that contain the different ways to add orders to a basket it sounded natural to reuse it. How does it look: Click on the add to basket link https://snag.gy/InG6NH.jpg Click on "From existing orders (copy)" https://snag.gy/1sgGw3.jpg Perform a search https://snag.gy/hJWbDd.jpg You can select some orders and redo another search (See "Refine search [+]" to expand the filters form). If a new search is done, the selected orders will stay selected even if they are not returned by the first request. They are put at the bottom (tfoot) of the table. https://snag.gy/4ojfHk.jpg When your selection is done, go to the next screen, to set some default values for these new orders. So far you can set a currency, fund, internal and vendor notes, as well as the two statistic fields. We have here the same form as when adding order from a staged file. We could add more if needed. There are also checkboxes in front of each field to copy the value from the existing order. If the checkbox is not ticked and that the input is empty, the value will be emptied. https://snag.gy/rDUH2u.jpg When you are done, submit the form. The next screen will display the new orders that have been created and attached to the basket. https://snag.gy/5MPqIH.jpg What happened exactly? The following value of aqorders have been set to default or null: ordernumber (AI), received_on, datereceived, datecancellationprinted, cancellationreason, purchaseordernumber, claims_count, claimed_date, parent_ordernumber placed_on and entrydate has been set to today orderstatus has been set to 'new' quantityreceived is 0 If items was attached to the order, new ones have been created with the exact same values (expect for barcode that has been removed to avoid collision) (Q) What about created_by? Should it be copied or set to the logged in user? (Q) What about users that are on receiving? So far nothing is done (not copied) (Q) What other fields do we want to batch edit before the duplication is done? What is still to be done: - Polish the interface a bit (any suggestions?) - Add tests for the two new methods added to Koha::Acquisition::Order (add_items and duplicate_to)
I have pushed a remote branch to ease testing: https://gitlab.com/joubu/Koha/tree/bug_15184
Created attachment 77513 [details] [review] Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 77514 [details] [review] Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 77515 [details] [review] Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 77516 [details] [review] Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 77517 [details] [review] Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? Sponsored-by: BULAC - http://www.bulac.fr/
There is a cosmetic issue in form for searching https://screenshots.firefox.com/FNkRRFxBZKgIwDey/localhost but overall it looks good
(In reply to Josef Moravec from comment #17) > There is a cosmetic issue in form for searching > > https://screenshots.firefox.com/FNkRRFxBZKgIwDey/localhost > > but overall it looks good Hi Josef, thanks for testing! The misplaced issue you see is not related to this patch, see bug 21223.
Created attachment 77966 [details] [review] Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77967 [details] [review] Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77968 [details] [review] Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77969 [details] [review] Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77970 [details] [review] Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78074 [details] [review] Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 78075 [details] [review] Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 78076 [details] [review] Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 78077 [details] [review] Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/
Created attachment 78078 [details] [review] Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? Sponsored-by: BULAC - http://www.bulac.fr/
QA scripts complain about missing POD: FAIL pod coverage POD is missing for add_user POD is missing for duplicate_to POD is missing for items POD is missing for users This looks a little odd: + <label for="fund">Fund: </label> + <select name="budget" id="fund"> Wondering about missing |html filters, especially in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt. Will continue testing - leaving some first notes as I'll have to come back to this later.
Also, can you please explain the last patch? Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving?
Hm, waiting for the last comment to be answered before more testing.
Created attachment 78277 [details] [review] Bug 15184: Add POD
Created attachment 78278 [details] [review] Bug 15184: add missing filters
(In reply to Katrin Fischer from comment #29) > QA scripts complain about missing POD: > FAIL pod coverage > POD is missing for add_user > POD is missing for duplicate_to > POD is missing for items > POD is missing for users Added in the last follow-up. > This looks a little odd: > + <label for="fund">Fund: </label> > + <select name="budget" id="fund"> Moved from acqui/histsearch.tt, existed before this patch. > Wondering about missing |html filters, especially in > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt. Added missing filters in a separate patch. (In reply to Katrin Fischer from comment #30) > Also, can you please explain the last patch? > > Bug 15184: Add users ? > > We certainly do not want this patch. What about users that are notified > on receiving? When an order is duplicated, do we want to duplicate the user list who were notified on receiving? I.e. they will be notified on receiving items for the duplicated order. I was not sure if it was wanted or not, so I put that code on a separate patch and waited for a feedback.
Created attachment 78279 [details] [review] Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78280 [details] [review] Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78281 [details] [review] Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78282 [details] [review] Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78283 [details] [review] Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78284 [details] [review] Bug 15184: Add POD
Created attachment 78285 [details] [review] Bug 15184: add missing filters
(In reply to Jonathan Druart from comment #39) > Created attachment 78283 [details] [review] [review] > Bug 15184: Add users ? > > We certainly do not want this patch. What about users that are notified > on receiving? > > Sponsored-by: BULAC - http://www.bulac.fr/ > > Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Could we make copying the users a checkbox or similar on the copy order form with default off? That way we might get us the best and most flexible behaviour.
I quite like the mechanics of this! Some questions: 1) Why another checkbox on the last step? (new from copy > search > select orders > copy order form > more checkboxes) 2) How do you handle items? Does it depend on what was set for the original order or is the setting for the current basket taken into account as well? 3) comment#42
Created attachment 78340 [details] [review] Bug 15184: Remove the checkboxes on the last step
(In reply to Katrin Fischer from comment #43) > I quite like the mechanics of this! Some questions: > > 1) Why another checkbox on the last step? (new from copy > search > select > orders > copy order form > more checkboxes) No sense, the last patch removes it. > 2) How do you handle items? Does it depend on what was set for the original > order or is the setting for the current basket taken into account as well? Items are copied, do you think they should only be copied if AcqCreateItem=placing an order? > 3) comment#42 (In reply to Katrin Fischer from comment #42) > Could we make copying the users a checkbox or similar on the copy order form > with default off? That way we might get us the best and most flexible > behaviour. I would suggest to either copy them or not, at least for a first step. And give more flexibility on another bug report.
Created attachment 78535 [details] [review] Bug 15184: Remove the checkboxes on the last step
Created attachment 78536 [details] [review] Bug 15184: Do not copy items for serials
Created attachment 78537 [details] [review] Bug 15184: Set created_by to the logged in user
Created attachment 78538 [details] [review] Bug 15184: Do copy items for not a serial OR if items are created on ordering
Created attachment 78539 [details] [review] Bug 15184: Set created_by to the logged in user
Created attachment 78697 [details] [review] Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78698 [details] [review] Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78699 [details] [review] Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78700 [details] [review] Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78701 [details] [review] Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78702 [details] [review] Bug 15184: Add POD
Created attachment 78703 [details] [review] Bug 15184: add missing filters
Created attachment 78704 [details] [review] Bug 15184: Remove the checkboxes on the last step
Created attachment 78705 [details] [review] Bug 15184: Do copy items for not a serial OR if items are created on ordering
Created attachment 78706 [details] [review] Bug 15184: Set created_by to the logged in user
Created attachment 78898 [details] [review] Bug 15184: Change permission (+x) on .pl
I find the duplicating page confusing. I figured after a while of looking at it that the checkbox is NOT related to the drop-down/text area next to it. The checkbox copies the original value, whereas the drop-down/text area adds a new value. It's not evident when looking at it since we're used to seeing check boxes next to the things we want. Furthermore, there is another design element that I find confusing. When I click on the checkbox next to the fund, "The original fund..." appears next to the checkbox for inactive funds, as if it was related to it (see screenshot).
Created attachment 78911 [details] Screenshot of duplcating page
- Move "Show inactive" checkbox closer to the "Show inactive" text. - Put more space between the "Show inactive" checkbox and the "The original..." text - Add "Check boxes to duplicate the original values" at the top of the blue box
Created attachment 78927 [details] [review] Bug 15184: Improve styling - Move "Show inactive" checkbox closer to the "Show inactive" text. - Put more space between the "Show inactive" checkbox and the "The original..." text - Add "Check boxes to duplicate the original values" at the top of the fieldset
With the last patch applied: https://snag.gy/uqnkpY.jpg
The new display seems better to me. Add a sentence like "To keep the original value, check the box." ?
Created attachment 78958 [details] [review] Bug 15184: Improve styling - Move "Show inactive" checkbox closer to the "Show inactive" text. - Put more space between the "Show inactive" checkbox and the "The original..." text - Add "Check boxes to duplicate the original values" at the top of the fieldset Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78959 [details] [review] Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78960 [details] [review] Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78961 [details] [review] Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78962 [details] [review] Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78963 [details] [review] Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78964 [details] [review] Bug 15184: Add POD Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78965 [details] [review] Bug 15184: add missing filters Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78966 [details] [review] Bug 15184: Remove the checkboxes on the last step Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78967 [details] [review] Bug 15184: Do copy items for not a serial OR if items are created on ordering Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78968 [details] [review] Bug 15184: Set created_by to the logged in user Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78969 [details] [review] Bug 15184: Change permission (+x) on .pl Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 78970 [details] [review] Bug 15184: Improve styling - Move "Show inactive" checkbox closer to the "Show inactive" text. - Put more space between the "Show inactive" checkbox and the "The original..." text - Add "Check boxes to duplicate the original values" at the top of the fieldset Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Should we leave out the "Bug 15184: Add users ? (2.30 KB, patch)" for testing this?
Created attachment 80485 [details] [review] Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80486 [details] [review] Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80487 [details] [review] Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80488 [details] [review] Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80489 [details] [review] Bug 15184: Add POD Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80490 [details] [review] Bug 15184: add missing filters Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80491 [details] [review] Bug 15184: Remove the checkboxes on the last step Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80492 [details] [review] Bug 15184: Do copy items for not a serial OR if items are created on ordering Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80493 [details] [review] Bug 15184: Set created_by to the logged in user Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80494 [details] [review] Bug 15184: Change permission (+x) on .pl Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 80495 [details] [review] Bug 15184: Improve styling - Move "Show inactive" checkbox closer to the "Show inactive" text. - Put more space between the "Show inactive" checkbox and the "The original..." text - Add "Check boxes to duplicate the original values" at the top of the fieldset Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
(In reply to Katrin Fischer from comment #81) > Should we leave out the "Bug 15184: Add users ? (2.30 KB, patch)" for > testing this? Yes, done.
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt FAIL filters missing_filter at line 284 ( <a class="btn btn-default" href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basket.basketno %]"><i class="fa fa-fw fa-arrow-left"></i> Return to the basket</a) missing_filter at line 98 ( [% order.groupname | html %] (<a href="basketgroup.pl?op=add&booksellerid=[% order.id | uri %]&basketgroupid=[% order.basketgroupid %]">[% order.basketgroupid | html %]</a>)) missing_filter at line 82 ( [% order.ordernumber %]) missing_filter at line 253 ( <a class="cancel" href="/cgi-bin/koha/acqui/duplicate_orders.pl?basketno=[% basket.basketno %]">Cancel</a>) missing_filter at line 114 ( <td><span title="[% order.creationdate %]">[% order.creationdate | $KohaDates %]</span></td>) Continueing testing!
Created attachment 80638 [details] [review] Bug 15184: Add missing html filters
Back to work here.
Created attachment 81435 [details] [review] Bug 15184: Fix TT filter
Created attachment 81436 [details] [review] Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81437 [details] [review] Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81438 [details] [review] Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81439 [details] [review] Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81440 [details] [review] Bug 15184: Add POD Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81441 [details] [review] Bug 15184: add missing filters Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81442 [details] [review] Bug 15184: Remove the checkboxes on the last step Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81443 [details] [review] Bug 15184: Do copy items for not a serial OR if items are created on ordering Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81444 [details] [review] Bug 15184: Set created_by to the logged in user Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81445 [details] [review] Bug 15184: Change permission (+x) on .pl Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81446 [details] [review] Bug 15184: Improve styling - Move "Show inactive" checkbox closer to the "Show inactive" text. - Put more space between the "Show inactive" checkbox and the "The original..." text - Add "Check boxes to duplicate the original values" at the top of the fieldset Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81447 [details] [review] Bug 15184: Add missing html filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81448 [details] [review] Bug 15184: Fix TT filter Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Phew.
Searching for basket created_by is broken, please add a followup
Created attachment 82079 [details] [review] Bug 15184: Fix bad merge conflict with created_by Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
New Feature, will not be backported to 18.05.x series.
I have not provided tests for the two new methods added to Koha::Acquisition::Order (oops!) It is now done on bug 22390. Also I think we did something wrong regarding the subscription tests. @BULAC could you take a look at the patch I have just submitted on bug 22390 and told us if you agree with the change?