Bug 15995 - Making libraries actions buttons
Summary: Making libraries actions buttons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-06 22:52 UTC by Aleisha Amohia
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15995: Moving libraries actions into a drop-down menu (4.38 KB, patch)
2016-03-06 22:59 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15995: Moving libraries actions into a drop-down menu (4.38 KB, patch)
2016-03-08 20:55 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 15995: Making libraries actions buttons (4.00 KB, patch)
2016-03-10 02:00 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15995: Making libraries actions buttons (4.10 KB, patch)
2016-03-11 16:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15995 [Follow-up] Making libraries actions buttons (1.83 KB, patch)
2016-03-11 16:50 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15995 [Follow-up] Making libraries actions buttons (2.56 KB, patch)
2016-03-13 21:26 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15995: Making libraries actions buttons (4.12 KB, patch)
2016-03-14 16:31 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15995 [Follow-up] Making libraries actions buttons (2.61 KB, patch)
2016-03-14 16:32 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Aleisha Amohia 2016-03-06 22:59:21 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2016-03-08 20:55:40 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-09 12:25:57 UTC
Comment on attachment 48828 [details] [review]
Bug 15995: Moving libraries actions into a drop-down menu

Review of attachment 48828 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
@@ +306,5 @@
>                                  <td>[% category.categorycode %]</td>
>                                  <td>[% category.codedescription %]</td>
>                                  <td>
> +                                  <div class="dropdown">
> +                                    <a class="btn btn-mini dropdown-toggle" id="libraryactions[% library.branchcode %]" role="button" data-toggle="dropdown" href="#">

library.branchcode will never be defined on deleting a group of libraries.
Comment 4 Jonathan Druart 2016-03-09 12:26:53 UTC
Note that the deletion of a group of libraries is broken, see bug 16015 for a fix.
Comment 5 Jonathan Druart 2016-03-09 12:29:17 UTC
Aleisha, putting this in discussion, it seems that we should use the drop-down menu only when we have more than 2 buttons.
Comment 6 Aleisha Amohia 2016-03-10 02:00:38 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2016-03-11 16:50:03 UTC Comment hidden (obsolete)
Comment 8 Owen Leonard 2016-03-11 16:50:07 UTC Comment hidden (obsolete)
Comment 9 Aleisha Amohia 2016-03-13 21:26:55 UTC Comment hidden (obsolete)
Comment 10 Jonathan Druart 2016-03-14 16:31:59 UTC
Created attachment 49117 [details] [review]
Bug 15995: Making libraries actions buttons

To test:

1) Go to Administration -> Libraries and Groups
2) Confirm that the actions 'Edit' and 'Delete' are now buttons for BOTH
   tables under one column 'Actions' and buttons behave as expected.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Jonathan Druart 2016-03-14 16:32:04 UTC
Created attachment 49118 [details] [review]
Bug 15995 [Follow-up] Making libraries actions buttons

This trivial follow-up adds an "actions" class to the table cell
containing the new buttons. In conjunction with the style update in Bug
16048, this will prevent the buttons from wrapping at narrow browser
window widths.

To test, apply the patch for Bug 16048 and go to Administration ->
Libraries and Groups.

Confirm that the "Edit" and "Delete" buttons do not wrap even at narrow
browser window widths.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
You forgot to add the class to one of the tables, but I have added it

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Brendan Gallagher 2016-03-18 07:08:58 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!