Like Bug 26512 and Bug 26478, there are some places in the OPAC where buttons were missed in the upgrade to Bootstrap 4. The following patch will clean up several instances.
Created attachment 110658 [details] [review] Bug 26519: Clean up OPAC buttons with incorrect classes This patch makes some corrections to the OPAC templates to add the correct classes to a few buttons which were missed during the Bootstrap 4 upgrade, especially in cases where the buttons only appear when JavaScript is disabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate the bibliographic record for a serial record and view the details. The subscription should have patron notification set. - Under the Subscriptions tab, the "Subscribe to email notifications" button should look correct. - Click to subscribe and confirm that the buttons during and after the process look correct. - Perform a catalog search in the OPAC. On the search results page, disable JavaScript. This can be done in the browser's developer tools under "Settings." - At the top of the table of search results there should be a correctly-styled "Go" button next to the sorting dropdown menu. It should work correctly. - View the contents of a list with JavaScript disabled. - The "Resort list" button should be correctly-styled and should work to submit the form.
Created attachment 110900 [details] [review] Bug 26519: Clean up OPAC buttons with incorrect classes This patch makes some corrections to the OPAC templates to add the correct classes to a few buttons which were missed during the Bootstrap 4 upgrade, especially in cases where the buttons only appear when JavaScript is disabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate the bibliographic record for a serial record and view the details. The subscription should have patron notification set. - Under the Subscriptions tab, the "Subscribe to email notifications" button should look correct. - Click to subscribe and confirm that the buttons during and after the process look correct. - Perform a catalog search in the OPAC. On the search results page, disable JavaScript. This can be done in the browser's developer tools under "Settings." - At the top of the table of search results there should be a correctly-styled "Go" button next to the sorting dropdown menu. It should work correctly. - View the contents of a list with JavaScript disabled. - The "Resort list" button should be correctly-styled and should work to submit the form. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 111460 [details] [review] Bug 26519: Clean up OPAC buttons with incorrect classes This patch makes some corrections to the OPAC templates to add the correct classes to a few buttons which were missed during the Bootstrap 4 upgrade, especially in cases where the buttons only appear when JavaScript is disabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate the bibliographic record for a serial record and view the details. The subscription should have patron notification set. - Under the Subscriptions tab, the "Subscribe to email notifications" button should look correct. - Click to subscribe and confirm that the buttons during and after the process look correct. - Perform a catalog search in the OPAC. On the search results page, disable JavaScript. This can be done in the browser's developer tools under "Settings." - At the top of the table of search results there should be a correctly-styled "Go" button next to the sorting dropdown menu. It should work correctly. - View the contents of a list with JavaScript disabled. - The "Resort list" button should be correctly-styled and should work to submit the form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
missing dependencies for 20.05.x, no backport