Bug 31687 - Add see from and see also from tracings in Match index (Elasticsearch, MARC21)
Summary: Add see from and see also from tracings in Match index (Elasticsearch, MARC21)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Caroline Cyr La Rose
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-05 13:55 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds see from and see also from terms for uniform title, chronological term, topical term, geographic name, and genre/form term to the Match index in Elasticsearch for MARC21. These will now be searchable in the Authorities module, by selecting the 'Search all headings' tab. Previously, only see from/see also from for personal names, corporate names, and meeting names were indexed and searchable this way.
Version(s) released in:
22.11.00


Attachments
Sample records (7.12 KB, text/plain)
2022-10-05 15:12 UTC, Caroline Cyr La Rose
Details
Bug 31687: Add see from and see also from tracings in Match index (3.81 KB, patch)
2022-10-05 15:12 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 31687: Add see from and see also from tracings in Match index (3.86 KB, patch)
2022-10-10 18:43 UTC, David Nind
Details | Diff | Splinter Review
Bug 31687: Add see from and see also from tracings in Match index (3.92 KB, patch)
2022-10-21 13:17 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2022-10-05 13:55:30 UTC
Some see from and see also from tracings are missing from the Match index. This means that if you search for a see from for a personal name, it will find it, but if you search for a see from for a topical term, it will not.

I was comparing zebra's index mappings with ES's, and found that these were missing from ES's Match index.

- 430(adfghklmnoprstvxyz)
- 448(avxyz)
- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)
- 530(adfghklmnoprstvxyz)
- 548(avxyz)
- 550(abvxyz)
- 551(avxyz)
- 555(avxyz)
Comment 1 Caroline Cyr La Rose 2022-10-05 15:12:01 UTC
Created attachment 141383 [details]
Sample records

Some authority records with see from and see also from tracings

Uniform title
Chronological name
Topical term
Geographic name
Genre/Form term
Comment 2 Caroline Cyr La Rose 2022-10-05 15:12:44 UTC
Created attachment 141384 [details] [review]
Bug 31687: Add see from and see also from tracings in Match index

This patch adds see from and see also from terms for uniform title,
chronological term, topical term, geographic name, and genre/form term
to the Match index in Elasticsearch for MARC21.

Previously, only see from/see also from for personal names,
corporate names, and meeting names were indexed.

To test:

1. Without patch, import attached authority records
1.1. Download attached records
1.2. Go to Tools > Stage MARC records for import
1.3. Click 'Browse' and choose the downloaded file
1.4. Click 'Upload file'
1.5. Choose Record type = Authority
1.6. Click 'Stage for import'
1.7. From the job details, click 'View batch'
1.8. Click 'Import this batch into the catalog'

2. Without patch, search for see from and see also from tracings
2.1. Go to Authorities
2.2. In the 'Default' drop-down menu, choose 'Uniform title'
2.3. Choose the 'Search all headings' tab
2.4. Enter the search term 'Five hundred'
2.5. Click 'Submit' or press 'Enter'
 --> No results
2.6. Redo the search for the following search terms

Authority type		Search term		Should be found in
Uniform title		five hundred		430
Uniform title		films préférés		530
Chronological term	fifteenth		448
Chronological term	middle ages		548
Topical term		lalopathie		450
Topical term		troubles communication	550
Geographic name	cécropia		451
Geographic name	canada francophone	551
Genre/Form term	filmiques		455
Genre/Form term	films			555

3. Apply patch
4. Delete index, reset mappings and reindex authorities (with command line, -a -d -r)
5. Redo the searches from step 2, there should now be results
Comment 3 David Nind 2022-10-10 18:43:48 UTC
Created attachment 141581 [details] [review]
Bug 31687: Add see from and see also from tracings in Match index

This patch adds see from and see also from terms for uniform title,
chronological term, topical term, geographic name, and genre/form term
to the Match index in Elasticsearch for MARC21.

Previously, only see from/see also from for personal names,
corporate names, and meeting names were indexed.

To test:

1. Without patch, import attached authority records
1.1. Download attached records
1.2. Go to Tools > Stage MARC records for import
1.3. Click 'Browse' and choose the downloaded file
1.4. Click 'Upload file'
1.5. Choose Record type = Authority
1.6. Click 'Stage for import'
1.7. From the job details, click 'View batch'
1.8. Click 'Import this batch into the catalog'

2. Without patch, search for see from and see also from tracings
2.1. Go to Authorities
2.2. In the 'Default' drop-down menu, choose 'Uniform title'
2.3. Choose the 'Search all headings' tab
2.4. Enter the search term 'Five hundred'
2.5. Click 'Submit' or press 'Enter'
 --> No results
2.6. Redo the search for the following search terms

Authority type		Search term		Should be found in
Uniform title		five hundred		430
Uniform title		films préférés		530
Chronological term	fifteenth		448
Chronological term	middle ages		548
Topical term		lalopathie		450
Topical term		troubles communication	550
Geographic name	cécropia		451
Geographic name	canada francophone	551
Genre/Form term	filmiques		455
Genre/Form term	films			555

3. Apply patch
4. Delete index, reset mappings and reindex authorities (with command line, -a -d -r)
5. Redo the searches from step 2, there should now be results

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-10-10 18:45:02 UTC
Thanks Caroline for the clear test plan and example records - these made it so easy to test!
Comment 5 Caroline Cyr La Rose 2022-10-11 14:31:05 UTC
(In reply to David Nind from comment #4)
> Thanks Caroline for the clear test plan and example records - these made it
> so easy to test!

Thanks David! I'm always afraid my very long test plans will scare away people lol!
Comment 6 Kyle M Hall 2022-10-21 13:17:17 UTC
Created attachment 142362 [details] [review]
Bug 31687: Add see from and see also from tracings in Match index

This patch adds see from and see also from terms for uniform title,
chronological term, topical term, geographic name, and genre/form term
to the Match index in Elasticsearch for MARC21.

Previously, only see from/see also from for personal names,
corporate names, and meeting names were indexed.

To test:

1. Without patch, import attached authority records
1.1. Download attached records
1.2. Go to Tools > Stage MARC records for import
1.3. Click 'Browse' and choose the downloaded file
1.4. Click 'Upload file'
1.5. Choose Record type = Authority
1.6. Click 'Stage for import'
1.7. From the job details, click 'View batch'
1.8. Click 'Import this batch into the catalog'

2. Without patch, search for see from and see also from tracings
2.1. Go to Authorities
2.2. In the 'Default' drop-down menu, choose 'Uniform title'
2.3. Choose the 'Search all headings' tab
2.4. Enter the search term 'Five hundred'
2.5. Click 'Submit' or press 'Enter'
 --> No results
2.6. Redo the search for the following search terms

Authority type		Search term		Should be found in
Uniform title		five hundred		430
Uniform title		films préférés		530
Chronological term	fifteenth		448
Chronological term	middle ages		548
Topical term		lalopathie		450
Topical term		troubles communication	550
Geographic name	cécropia		451
Geographic name	canada francophone	551
Genre/Form term	filmiques		455
Genre/Form term	films			555

3. Apply patch
4. Delete index, reset mappings and reindex authorities (with command line, -a -d -r)
5. Redo the searches from step 2, there should now be results

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2022-10-21 14:46:55 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!