Bug 31690 - Add see from tracings in See-from index (Elasticsearch, MARC21)
Summary: Add see from tracings in See-from index (Elasticsearch, MARC21)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Caroline Cyr La Rose
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-05 15:35 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds fields 450, 451, and 455 to the See-from index for MARC21. Previously, only 400, 410, 411, 430, 447, 448, and 462 were indexed.
Version(s) released in:
22.11.00


Attachments
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) (1.26 KB, patch)
2022-10-05 15:38 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) (1.31 KB, patch)
2022-10-10 19:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) (1.36 KB, patch)
2022-10-21 11:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) (1.42 KB, patch)
2022-10-24 15:01 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2022-10-05 15:35:57 UTC
Some see from tracings are indexed in See-from, but not all.

Currently indexed are 400, 410, 411, 430, 440, 441, 444, 447, 448, and 462. Missing are 450, 451, and 455.

Also, 440, 441, and 444 are not valid MARC fields. But that is something for another bug...

I'm not sure exactly where this index is used, but I figure it's best that the index be complete rather than indexing only some types of authorities.
Comment 1 Caroline Cyr La Rose 2022-10-05 15:38:45 UTC
Created attachment 141386 [details] [review]
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21)

This patch adds the following fields to the See-from index

- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)
Comment 2 Caroline Cyr La Rose 2022-10-05 15:41:13 UTC
Sorry, I'm not sure where this index is used so I don't know how to test...
Comment 3 David Nind 2022-10-10 19:26:08 UTC
Created attachment 141585 [details] [review]
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21)

This patch adds the following fields to the See-from index

- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-10-10 19:28:04 UTC
"Tested" by comparing the list of fields added with the Library of Congress definitions[1] to make sure they exist.

[1] https://www.loc.gov/marc/authority/ad4xx.html
Comment 5 Kyle M Hall 2022-10-21 11:34:19 UTC
Created attachment 142334 [details] [review]
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21)

This patch adds the following fields to the See-from index

- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2022-10-24 14:47:33 UTC
Please rebase
Comment 7 Caroline Cyr La Rose 2022-10-24 15:01:29 UTC
Created attachment 142518 [details] [review]
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21)

This patch adds the following fields to the See-from index

- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Caroline Cyr La Rose 2022-10-24 15:02:29 UTC
I rebased it. I wasn't sure which status to put it in after
Comment 9 Katrin Fischer 2022-10-24 16:36:14 UTC
If you feel it's not a totally different patch/are confident it's still working, you can go back to PQA straight away :)
Comment 10 Tomás Cohen Arazi 2022-10-24 17:41:42 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!