Some see from tracings are indexed in See-from, but not all. Currently indexed are 400, 410, 411, 430, 440, 441, 444, 447, 448, and 462. Missing are 450, 451, and 455. Also, 440, 441, and 444 are not valid MARC fields. But that is something for another bug... I'm not sure exactly where this index is used, but I figure it's best that the index be complete rather than indexing only some types of authorities.
Created attachment 141386 [details] [review] Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) This patch adds the following fields to the See-from index - 450(abvxyz) - 451(avxyz) - 455(avxyz)
Sorry, I'm not sure where this index is used so I don't know how to test...
Created attachment 141585 [details] [review] Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) This patch adds the following fields to the See-from index - 450(abvxyz) - 451(avxyz) - 455(avxyz) Signed-off-by: David Nind <david@davidnind.com>
"Tested" by comparing the list of fields added with the Library of Congress definitions[1] to make sure they exist. [1] https://www.loc.gov/marc/authority/ad4xx.html
Created attachment 142334 [details] [review] Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) This patch adds the following fields to the See-from index - 450(abvxyz) - 451(avxyz) - 455(avxyz) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Please rebase
Created attachment 142518 [details] [review] Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) This patch adds the following fields to the See-from index - 450(abvxyz) - 451(avxyz) - 455(avxyz) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I rebased it. I wasn't sure which status to put it in after
If you feel it's not a totally different patch/are confident it's still working, you can go back to PQA straight away :)
Pushed to master for 22.11. Nice work everyone, thanks!