Bug 31689 - Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21)
Summary: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Caroline Cyr La Rose
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-05 15:25 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds fields 430, 448, 450, 451, and 455 to the Match-heading-see-from. Previously, only 400, 410, and 411 were indexed.
Version(s) released in:
22.11.00


Attachments
Bug 31689: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) (1.54 KB, patch)
2022-10-05 15:29 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 31689: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) (1.59 KB, patch)
2022-10-10 19:36 UTC, David Nind
Details | Diff | Splinter Review
Bug 31689: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21) (1.64 KB, patch)
2022-10-21 11:33 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2022-10-05 15:25:19 UTC
Some see from tracings are indexed in Match-heading-see-from, but not all.

Currently indexed are 400, 410, and 411. Missing are 430, 448, 450, 451, and 455.

I'm not sure exactly where this index is used, but I figure it's best that the index be complete rather than indexing only some types of authorities.
Comment 1 Caroline Cyr La Rose 2022-10-05 15:29:03 UTC
Created attachment 141385 [details] [review]
Bug 31689: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21)

This patch adds the following fields to the Match-heading-see-from index

- 430(adfghklmnoprstvxyz)
- 448(avxyz)
- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)
Comment 2 Caroline Cyr La Rose 2022-10-05 15:31:35 UTC
Sorry, not sure how to test since I don't know where that index is used...
Comment 3 David Nind 2022-10-10 19:36:28 UTC
Created attachment 141586 [details] [review]
Bug 31689: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21)

This patch adds the following fields to the Match-heading-see-from index

- 430(adfghklmnoprstvxyz)
- 448(avxyz)
- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-10-10 19:37:13 UTC
"Tested" by comparing the list of fields added to the index with the Library of Congress definitions[1] to make sure they exist.

[1] https://www.loc.gov/marc/authority/ad4xx.html
Comment 5 Kyle M Hall 2022-10-21 11:33:01 UTC
Created attachment 142333 [details] [review]
Bug 31689: Add see from tracings in Match-heading-see-from index (Elasticsearch, MARC21)

This patch adds the following fields to the Match-heading-see-from index

- 430(adfghklmnoprstvxyz)
- 448(avxyz)
- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2022-10-24 14:45:41 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!