Bug 34390 - Inconsistencies in Credit types page titles, breadcrumbs, and header
Summary: Inconsistencies in Credit types page titles, breadcrumbs, and header
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34396
  Show dependency treegraph
 
Reported: 2023-07-25 18:17 UTC by Caroline Cyr La Rose
Modified: 2023-10-14 12:14 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other.
Version(s) released in:
23.11.00


Attachments
Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header (2.69 KB, patch)
2023-10-02 16:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header (2.73 KB, patch)
2023-10-03 00:02 UTC, David Nind
Details | Diff | Splinter Review
Bug 34390: (follow-up) Add single quotes around credit type (2.10 KB, patch)
2023-10-03 00:02 UTC, David Nind
Details | Diff | Splinter Review
Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header (2.68 KB, patch)
2023-10-03 11:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34390: (follow-up) Add single quotes around credit type (2.15 KB, patch)
2023-10-03 11:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header (2.79 KB, patch)
2023-10-07 14:25 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34390: (follow-up) Add single quotes around credit type (2.20 KB, patch)
2023-10-07 14:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-07-25 18:17:55 UTC
While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. 

For the Credit types page, here is what should be changed to make it consistent with the other pages in the module:

Page title
- Add credit type code to Modify X (e.g. Modify credit type 'CREDIT')

Breadcrumb
- Add credit type code to Modify X (e.g. Modify credit type 'CREDIT')

Page header
- Change 'Modify a credit type' to "Modify credit type 'Y'"
Comment 1 Owen Leonard 2023-10-02 16:00:29 UTC
Created attachment 156458 [details] [review]
Bug 34390:  Fix inconsistencies in credit types titles, breadcrumbs, and header

Fix inconsistencies in credit types titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the credit types
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Credit types. Test
each variation of the page:

- Main page
- New credit type
- Modify credit type
Comment 2 David Nind 2023-10-03 00:02:13 UTC
Created attachment 156467 [details] [review]
Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header

Fix inconsistencies in credit types titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the credit types
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Credit types. Test
each variation of the page:

- Main page
- New credit type
- Modify credit type

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-10-03 00:02:16 UTC
Created attachment 156468 [details] [review]
Bug 34390: (follow-up) Add single quotes around credit type

For consistency with other bugs - adds single quotes around the
credit type code.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-10-03 00:05:20 UTC
Feel free to obsolete my follow-up patch - bug 34389 (debit types) and bug 34391 (cash registers) had single quotes around the debit and cash register code values.
Comment 5 Owen Leonard 2023-10-03 11:09:51 UTC
Created attachment 156496 [details] [review]
Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header

Fix inconsistencies in credit types titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the credit types
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Credit types. Test
each variation of the page:

- Main page
- New credit type
- Modify credit type
Comment 6 Owen Leonard 2023-10-03 11:09:54 UTC
Created attachment 156497 [details] [review]
Bug 34390: (follow-up) Add single quotes around credit type

For consistency with other bugs - adds single quotes around the
credit type code.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Katrin Fischer 2023-10-07 14:25:27 UTC
Created attachment 156676 [details] [review]
Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header

Fix inconsistencies in credit types titles, breadcrumbs, and header

This patch fixes a couple of inconsistencies in the credit types
administration page, making sure the page title, breadcrumb
navigation, and page headers are consistent with each other.

To test, apply the patch and go to Administration -> Credit types. Test
each variation of the page:

- Main page
- New credit type
- Modify credit type

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2023-10-07 14:25:30 UTC
Created attachment 156677 [details] [review]
Bug 34390: (follow-up) Add single quotes around credit type

For consistency with other bugs - adds single quotes around the
credit type code.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2023-10-09 14:43:00 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Fridolin Somers 2023-10-09 19:14:20 UTC
Enhancement not pushed to 23.05.x