Bug 34553 - Update send list and send cart popup footers
Summary: Update send list and send cart popup footers
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 34343
Blocks: 34562 34566
  Show dependency treegraph
 
Reported: 2023-08-17 06:57 UTC by Owen Leonard
Modified: 2023-09-25 12:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34553: Update send list and send cart popup footers (8.64 KB, patch)
2023-08-17 08:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34553: Update send list and send cart popup footers (8.93 KB, patch)
2023-08-17 10:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34553: Update send list and send cart popup footers (9.03 KB, patch)
2023-09-21 21:05 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-08-17 06:57:16 UTC
Like Bug 34343, I would like to add a fixed footer to the "send list" and "send cart" popups in the staff interface, making them consistent with Z39.50 and quick spine label (Bug 34453) popups.
Comment 1 Owen Leonard 2023-08-17 08:14:11 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-08-17 10:30:29 UTC Comment hidden (obsolete)
Comment 3 Andrew Auld 2023-08-17 12:30:04 UTC
Tested on the Biblibre Sandbox 17/08/2023
Works beautifully
Comment 4 Katrin Fischer 2023-09-21 21:05:24 UTC
Created attachment 156013 [details] [review]
Bug 34553: Update send list and send cart popup footers

This patch updates the templates behind the "send cart" and "send list"
pop-ups in order to make the style of the footer consistent with some
recently-updated similar examples, like the catalog's Z39.50 search
popup.

The patch also makes a minor change to our global JavaScript include so
we can get away from using the "close" class as a trigger for closing a
pop-up window. Bootstrap has a built-in "close" class that we always
have to override. "close_window" is added as another class to use, and
the other instances can be cleaned up overy time.

To test, apply the patch and perform a catalog search in the staff
interface.

 - Add one or more items to the cart.
 - Open the cart popup and click the "Send" button.
 - In the pop-up window, confirm that the footer looks correct.
 - Test the process of using the tab key between input fields and
   submit/cancel buttons. All controls should be accessible.
 - Test the "Cancel" button to confirm that it closes the window.
 - Reopen the window and test sending the email.
 - On the confirmation page, confirm that the footer looks correct and
   that the "Close window" button works.

 - Test the same processes in the Lists module: View a list in the staff
   interface and test the process of sending a list.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-09-22 14:35:10 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-22 19:51:53 UTC
Enhancement not pushed to 23.05.x