Bug 34566 - Update MARC21 cataloging plugins with consistent footers
Summary: Update MARC21 cataloging plugins with consistent footers
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 34343 34553 34630
Blocks: 34661
  Show dependency treegraph
 
Reported: 2023-08-17 12:42 UTC by Owen Leonard
Modified: 2023-12-13 22:18 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/788
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34566: Update MARC21 cataloging plugins with consistent footers (26.54 KB, patch)
2023-08-30 16:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34566: Update MARC21 cataloging plugins with consistent footers (26.70 KB, patch)
2023-09-12 18:19 UTC, Emily-Rose Francoeur
Details | Diff | Splinter Review
Bug 34566: Update MARC21 cataloging plugins with consistent footers (26.75 KB, patch)
2023-10-07 17:27 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-08-17 12:42:40 UTC
I propose to update these MARC21 cataloging plugin pages to use consistent styling for pop-up window footers:

- EXAMPLE.tt (as an example)
- marc21_field_006.tt
- marc21_field_007.tt
- marc21_field_008.tt
- marc21_field_008_authorities.tt
- marc21_field_008_classifications.tt
Comment 1 Owen Leonard 2023-08-30 16:34:36 UTC
Created attachment 154976 [details] [review]
Bug 34566: Update MARC21 cataloging plugins with consistent footers

This patch updates MARC21 cataloging plugin templates so that submit and
cancel controls are consistently displayed in a fixed footer.

To test, apply the patch and go to Cataloging.

- Create or edit a bibliographic record
- Test the cataloging plugins for these fields:
  - 000 (Leader)
  - 006
  - 007
  - 008
  - In each case, confirm that the correct popup window is shown when
    you click the plugin link.
  - Confirm that clicking the "Cancel" button closes the window without
    copying any data to the field in the MARC editor.
    * Note that if the plugin is also triggered by cursor focus in the
      input field, some data may be automatically filled anyway.
  - Confirm that filing in data and clicking "Submit" will copy the
    correct information into the field.

- Go to Authorities and create or edit an authority record.
- Test the plugin for these fields:
  - 000 (Leader)
  - 008
 - Perform the same tests as above.

I don't think the marc21_field_008_classifications is used at all, but
the template has been updated anyway. To test, edit your authority
record to use the plugin:

 - Administration -> Authority types -> Default -> MARC structure -> 008
   -> Subfields -> Edit.
 - Under Advanced constraints -> Plugin, select
   "marc21_field_008_classifcations.pl"
 - Re-test the behavior of the authority editor's tag 008 plugin to
   confirm that this plugin is used and works correctly.
Comment 2 Emily-Rose Francoeur 2023-09-12 18:19:11 UTC
Created attachment 155568 [details] [review]
Bug 34566: Update MARC21 cataloging plugins with consistent footers

This patch updates MARC21 cataloging plugin templates so that submit and
cancel controls are consistently displayed in a fixed footer.

To test, apply the patch and go to Cataloging.

- Create or edit a bibliographic record
- Test the cataloging plugins for these fields:
  - 000 (Leader)
  - 006
  - 007
  - 008
  - In each case, confirm that the correct popup window is shown when
    you click the plugin link.
  - Confirm that clicking the "Cancel" button closes the window without
    copying any data to the field in the MARC editor.
    * Note that if the plugin is also triggered by cursor focus in the
      input field, some data may be automatically filled anyway.
  - Confirm that filing in data and clicking "Submit" will copy the
    correct information into the field.

- Go to Authorities and create or edit an authority record.
- Test the plugin for these fields:
  - 000 (Leader)
  - 008
 - Perform the same tests as above.

I don't think the marc21_field_008_classifications is used at all, but
the template has been updated anyway. To test, edit your authority
record to use the plugin:

 - Administration -> Authority types -> Default -> MARC structure -> 008
   -> Subfields -> Edit.
 - Under Advanced constraints -> Plugin, select
   "marc21_field_008_classifcations.pl"
 - Re-test the behavior of the authority editor's tag 008 plugin to
   confirm that this plugin is used and works correctly.

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Comment 3 Katrin Fischer 2023-10-07 17:27:30 UTC
Created attachment 156687 [details] [review]
Bug 34566: Update MARC21 cataloging plugins with consistent footers

This patch updates MARC21 cataloging plugin templates so that submit and
cancel controls are consistently displayed in a fixed footer.

To test, apply the patch and go to Cataloging.

- Create or edit a bibliographic record
- Test the cataloging plugins for these fields:
  - 000 (Leader)
  - 006
  - 007
  - 008
  - In each case, confirm that the correct popup window is shown when
    you click the plugin link.
  - Confirm that clicking the "Cancel" button closes the window without
    copying any data to the field in the MARC editor.
    * Note that if the plugin is also triggered by cursor focus in the
      input field, some data may be automatically filled anyway.
  - Confirm that filing in data and clicking "Submit" will copy the
    correct information into the field.

- Go to Authorities and create or edit an authority record.
- Test the plugin for these fields:
  - 000 (Leader)
  - 008
 - Perform the same tests as above.

I don't think the marc21_field_008_classifications is used at all, but
the template has been updated anyway. To test, edit your authority
record to use the plugin:

 - Administration -> Authority types -> Default -> MARC structure -> 008
   -> Subfields -> Edit.
 - Under Advanced constraints -> Plugin, select
   "marc21_field_008_classifcations.pl"
 - Re-test the behavior of the authority editor's tag 008 plugin to
   confirm that this plugin is used and works correctly.

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-10-09 14:43:23 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-09 18:48:05 UTC
Enhancement not pushed to 23.05.x