Bug 34849 - Use template wrapper for breadcrumbs: OPAC part 1
Summary: Use template wrapper for breadcrumbs: OPAC part 1
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34852 34855 34866
  Show dependency treegraph
 
Reported: 2023-09-20 14:28 UTC by Owen Leonard
Modified: 2024-07-04 20:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:


Attachments
Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 (42.64 KB, patch)
2023-09-20 15:06 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 (42.65 KB, patch)
2023-09-20 15:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 (43.00 KB, patch)
2023-09-20 18:03 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 (43.00 KB, patch)
2023-10-13 10:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 (43.05 KB, patch)
2023-10-13 10:51 UTC, Philip Orr
Details | Diff | Splinter Review
Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1 (43.10 KB, patch)
2023-10-14 15:45 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-09-20 14:28:45 UTC
To continue the process started by Bug 32507, this patch will update several templates in the OPAC so that they use a template wrapper for breadcrumbs.

- errors/errorpage.tt
- opac-account.tt
- opac-auth.tt
- opac-curbside-pickups.tt
- opac-discharge.tt
- opac-holdshistory.tt
- opac-illrequests.tt
- opac-memberentry-update-submitted.tt
- opac-memberentry.tt
- opac-messaging.tt
- opac-passwd.tt
- opac-password-recovery.tt
- opac-patron-consent.tt
- opac-privacy.tt
- opac-readingrecord.tt
- opac-recalls.tt
- opac-reset-password.tt
- opac-routing-lists.tt
- opac-search-history.tt
- opac-shelves.tt
- opac-tags.tt
- opac-user.tt
Comment 1 Owen Leonard 2023-09-20 15:06:29 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-09-20 15:16:53 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2023-09-20 18:03:16 UTC
Created attachment 155959 [details] [review]
Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

The patch contains a minor CSS update, so you will have to rebuild the
OPAC CSS for testings.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- User summary
- Charges
- Personal details
  - Submit changes
- Consents (with PrivacyPolicyConsent enabled)
- Tags
- Change password
  - Submit password change
- Search history
  - Test when logged in and when not logged in
- Checkout history
- Privacy
- Holds history
- Recalls history
- Messaging (with  EnhancedMessagingPreferences
  and EnhancedMessagingPreferencesOPAC enabled).
- Lists
  - View private list
  - View public list
  - Edit list
  - Share list
    - Submit invitation
  - Create list
  - View list contents
- Routing lists (with RoutingSerials enabled)
- Ask for a discharge (with useDischarge enabled)
- ILL requests
- Curbside pickups
- Error page: Navigate to a non-existent page
Comment 4 Philip Orr 2023-10-13 08:37:02 UTC
Every page except "Routing lists" has the correct links in the breadcrumb
and everything looks correct.

For "Routing lists" though, in the breadcrumb, the link to the
user account links to .../cgi-bin/koha/opac-routing-lists.pl
instead of .../cgi-bin/koha/opac-user.pl
Comment 5 Philip Orr 2023-10-13 08:38:51 UTC
Also, qa complained about some lines:

Processing files before patches
Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 346.
Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 349.
|========================>| 24 / 24 (100.00%)
Processing files after patches
Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 341.
Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 344.
|========================>| 24 / 24 (100.00%)

Though everything still checked out OK, so I don't know if it's important.
Comment 6 Owen Leonard 2023-10-13 10:37:44 UTC
Created attachment 157054 [details] [review]
Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

The patch contains a minor CSS update, so you will have to rebuild the
OPAC CSS for testings.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- User summary
- Charges
- Personal details
  - Submit changes
- Consents (with PrivacyPolicyConsent enabled)
- Tags
- Change password
  - Submit password change
- Search history
  - Test when logged in and when not logged in
- Checkout history
- Privacy
- Holds history
- Recalls history
- Messaging (with  EnhancedMessagingPreferences
  and EnhancedMessagingPreferencesOPAC enabled).
- Lists
  - View private list
  - View public list
  - Edit list
  - Share list
    - Submit invitation
  - Create list
  - View list contents
- Routing lists (with RoutingSerials enabled)
- Ask for a discharge (with useDischarge enabled)
- ILL requests
- Curbside pickups
- Error page: Navigate to a non-existent page
Comment 7 Philip Orr 2023-10-13 10:51:33 UTC
Created attachment 157064 [details] [review]
Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

The patch contains a minor CSS update, so you will have to rebuild the
OPAC CSS for testings.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- User summary
- Charges
- Personal details
  - Submit changes
- Consents (with PrivacyPolicyConsent enabled)
- Tags
- Change password
  - Submit password change
- Search history
  - Test when logged in and when not logged in
- Checkout history
- Privacy
- Holds history
- Recalls history
- Messaging (with  EnhancedMessagingPreferences
  and EnhancedMessagingPreferencesOPAC enabled).
- Lists
  - View private list
  - View public list
  - Edit list
  - Share list
    - Submit invitation
  - Create list
  - View list contents
- Routing lists (with RoutingSerials enabled)
- Ask for a discharge (with useDischarge enabled)
- ILL requests
- Curbside pickups
- Error page: Navigate to a non-existent page

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 8 Katrin Fischer 2023-10-14 15:45:37 UTC
Created attachment 157154 [details] [review]
Bug 34849: Use template wrapper for breadcrumbs: OPAC part 1

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

The patch contains a minor CSS update, so you will have to rebuild the
OPAC CSS for testings.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- User summary
- Charges
- Personal details
  - Submit changes
- Consents (with PrivacyPolicyConsent enabled)
- Tags
- Change password
  - Submit password change
- Search history
  - Test when logged in and when not logged in
- Checkout history
- Privacy
- Holds history
- Recalls history
- Messaging (with  EnhancedMessagingPreferences
  and EnhancedMessagingPreferencesOPAC enabled).
- Lists
  - View private list
  - View public list
  - Edit list
  - Share list
    - Submit invitation
  - Create list
  - View list contents
- Routing lists (with RoutingSerials enabled)
- Ask for a discharge (with useDischarge enabled)
- ILL requests
- Curbside pickups
- Error page: Navigate to a non-existent page

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi (tcohen) 2023-10-18 13:23:09 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Fridolin Somers 2023-10-25 07:17:17 UTC
This is more an enhancement, not backported to 23.05.x