Bug 34852 - Use template wrapper for breadcrumbs: OPAC part 2
Summary: Use template wrapper for breadcrumbs: OPAC part 2
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 34849
Blocks:
  Show dependency treegraph
 
Reported: 2023-09-20 15:21 UTC by Owen Leonard
Modified: 2023-10-25 07:17 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2 (25.32 KB, patch)
2023-09-20 18:29 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2 (25.37 KB, patch)
2023-10-13 10:23 UTC, Philip Orr
Details | Diff | Splinter Review
Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2 (25.37 KB, patch)
2023-10-13 10:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2 (25.43 KB, patch)
2023-10-14 15:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-09-20 15:21:55 UTC
To continue the process started by Bug 32507, this patch will update several templates in the OPAC so that they use the new template wrapper for breadcrumbs.

- ilsdi.tt
- opac-ISBDdetail.tt
- opac-MARCdetail.tt
- opac-advsearch.tt
- opac-alert-subscribe.tt
- opac-auth-MARCdetail.tt
- opac-auth-detail.tt
- opac-authorities-home.tt
- opac-authoritiessearchresultlist.- 
- opac-blocked.tt
- opac-browse.tt
- opac-browser.tt
Comment 1 Owen Leonard 2023-09-20 18:29:05 UTC Comment hidden (obsolete)
Comment 2 Philip Orr 2023-10-13 10:23:36 UTC Comment hidden (obsolete)
Comment 3 Philip Orr 2023-10-13 10:24:58 UTC
(In reply to Philip Orr from comment #2)
> - Try to view a bibliographic record which is suppressed in the
>   OPAC. Requires OpacSuppression enabled and OpacSuppressionRedirect set
>   to "An explanatory page"
>   - Set the value of 952$n to 1 to suppress it in the OPAC.

That should be 942$n. :-)
Comment 4 Owen Leonard 2023-10-13 10:45:01 UTC
Created attachment 157055 [details] [review]
Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- Navigate to /cgi-bin/koha/ilsdi.pl
  - Check a variety of links in the list
- Advanced search
  - Locate a bibliographic record and view the ISBD detail page
  - View the MARC detail page
- Locate a serial record which has a patron notification notice defined
  in its subscription details
  - On the detail view under the "Subscriptions" tab, click the
    "Subscribe to email notification on new issues" button.
    - Confirm the subscription, then when you return to the detail page,
      click "Cancel email notification" to check that view as well.
- Authority search
  - Perform a search which will return results
    - Click the "Details" link on one of the results
      - Also view the "MARC view" tab (note that I didn't address the
        breadcrumb inconsistency between the normal and MARC view in
        this patch).
- Try to view a bibliographic record which is suppressed in the
  OPAC. Requires OpacSuppression enabled and OpacSuppressionRedirect set
  to "An explanatory page"
  - Set the value of 942$n to 1 to suppress it in the OPAC.
- In a system with ElasticSearch enabled, go to "Browse search" (or
  navigate directly to /cgi-bin/koha/opac-browse.pl
- With  OpacBrowser enabled, go to "Browse by hierarchy."

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 5 Katrin Fischer 2023-10-14 15:52:05 UTC
Created attachment 157155 [details] [review]
Bug 34852: Use template wrapper for breadcrumbs: OPAC part 2

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- Navigate to /cgi-bin/koha/ilsdi.pl
  - Check a variety of links in the list
- Advanced search
  - Locate a bibliographic record and view the ISBD detail page
  - View the MARC detail page
- Locate a serial record which has a patron notification notice defined
  in its subscription details
  - On the detail view under the "Subscriptions" tab, click the
    "Subscribe to email notification on new issues" button.
    - Confirm the subscription, then when you return to the detail page,
      click "Cancel email notification" to check that view as well.
- Authority search
  - Perform a search which will return results
    - Click the "Details" link on one of the results
      - Also view the "MARC view" tab (note that I didn't address the
        breadcrumb inconsistency between the normal and MARC view in
        this patch).
- Try to view a bibliographic record which is suppressed in the
  OPAC. Requires OpacSuppression enabled and OpacSuppressionRedirect set
  to "An explanatory page"
  - Set the value of 942$n to 1 to suppress it in the OPAC.
- In a system with ElasticSearch enabled, go to "Browse search" (or
  navigate directly to /cgi-bin/koha/opac-browse.pl
- With  OpacBrowser enabled, go to "Browse by hierarchy."

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-10-18 13:23:12 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-10-25 07:17:52 UTC
This is more an enhancement, not backported to 23.05.x