Description
Kyle M Hall
2013-05-21 16:14:48 UTC
Created attachment 18272 [details] [review] Bug 10300 - Revert Bug 8781 - Access to Transfer page while "independent branches" is on This bug needs reverted, this explanation was given to me by a librarian: For our group it is useful in order to allow the library to "fix" items that they receive from other libraries for holds requests that have either not been transferred properly by the lending library, so the item was never processed through check in to be placed "in transit," -- there are frequent enough occasions when a library is filling hold requests from their queue and the transfer is not completely placed into effect -- the status will be changed to "in transit" but the "Current Location" is not updated to the borrowing library. In these instances, the item arrives at the borrowing location, they scan it at check in and get the message "Item must be checked in at home library." In both of these cases, without the "Transfer" ability, I have to make the transfer for them. This is not a workable situation. It is far too manual a system if I have to personally transfer items to libraries myself to correct both of these situations. Test Plan: 1) As a non-superlibrarian, navigate to circulation-home.pl 2) Note the transfer option is non-existant 3) Apply this patch 4) Refresh circulation-home.pl 5) Note the transfer option is displayed This reverts commit c101f779e587217ae5ac46ee18aa0292c30aa808. I'm not trying to dispute, just want a confirmation - the problem you describe would occur only with independent branches. Is that a legitimate scenario to transfer between independent branches on daily bases? (In reply to comment #0) > This bug needs reverted, this explanation was given to me by a librarian: I don't think a revert is the way to do it, particularly since we're talking about a patch that's been pushed to several stable branches. Simply reverting would create a regression for the folks who filed bug 8781 in the first place. I think the key words in your customer's statement is "for our group". I suspect it is not every user of IndependentBranches who needs to "fix" items on a regular basis, but I certainly understand and appreciate that some do. To me, this situation calls for either a new user permission or YASP. Setting to "in discussion". Created attachment 54880 [details] [review] Bug 10300 - Allow transferring of items to be have separate IndependentBranches syspref Some libraries want to have IndependentBranches enabled, but still be able to transfer items between themselves. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndpendentBranches and IndependentBranchesTransfers 4) Log in as a super librarian 5) Note you can transfer items 6) Log in as a non-super librarian 7) Note you cannot transfer items 8) Disable IndependentBranchesTransfers 9) Note you can now transfer items Created attachment 54939 [details] [review] [SIGNED-OFF] Bug 10300 - Allow transferring of items to be have separate IndependentBranches syspref Some libraries want to have IndependentBranches enabled, but still be able to transfer items between themselves. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndpendentBranches and IndependentBranchesTransfers 4) Log in as a super librarian 5) Note you can transfer items 6) Log in as a non-super librarian 7) Note you cannot transfer items 8) Disable IndependentBranchesTransfers 9) Note you can now transfer items Signed-off-by: Maribeth Shafer <mshafer@ckls.org> As bug 15758 is going to pass QA soon, it would be good to rebase this patch on top of it. CONFLICT (content): Merge conflict in circ/branchtransfers.pl Created attachment 85880 [details] [review] Bug 10300: Allow transferring of items to be have separate IndependentBranches syspref Some libraries want to have IndependentBranches enabled, but still be able to transfer items between themselves. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndpendentBranches and IndependentBranchesTransfers 4) Log in as a super librarian 5) Note you can transfer items 6) Log in as a non-super librarian 7) Note you cannot transfer items 8) Disable IndependentBranchesTransfers 9) Note you can now transfer items Signed-off-by: Maribeth Shafer <mshafer@ckls.org> Created attachment 85881 [details] [review] Bug 10300: (follow-up) add controls on transfers page This patch moves the check of IndependentBranchesTransfers pref to templates and adds permission test inside branchtransfers.pl. It also corrects the libraries combobox in branchtransfers.tt, this list can contain all libraries, it is the access to the page that may be protected. Additions to test plan : 1) 1.1) Enable CircSidebar 1.2) In circulation home page check the effect of IndependentBranchesTransfers on "Transfer" link 1.3) Go to return page and check then effect of IndependentBranchesTransfers on "Transfer" link 2) 2.1) In circ/branchtransfers.pl, with and without IndependentBranches you see all libraries are in combobox 3) 3.1) Set IndependentBranchesTransfers to no and go to circ/branchtransfers.pl 3.2) You are redirected to page 403 unless you are superlibarian I wonder if this can still be considered a major bug after 6 years? Maybe it could be seen as an enh at this point? I agree, this is an enhancement at this point in reality. It does appear to work so I'm going to SO too. Created attachment 86521 [details] [review] Bug 10300: Allow transferring of items to be have separate IndependentBranches syspref Some libraries want to have IndependentBranches enabled, but still be able to transfer items between themselves. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndpendentBranches and IndependentBranchesTransfers 4) Log in as a super librarian 5) Note you can transfer items 6) Log in as a non-super librarian 7) Note you cannot transfer items 8) Disable IndependentBranchesTransfers 9) Note you can now transfer items Signed-off-by: Maribeth Shafer <mshafer@ckls.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86522 [details] [review] Bug 10300: (follow-up) add controls on transfers page This patch moves the check of IndependentBranchesTransfers pref to templates and adds permission test inside branchtransfers.pl. It also corrects the libraries combobox in branchtransfers.tt, this list can contain all libraries, it is the access to the page that may be protected. Additions to test plan : 1) 1.1) Enable CircSidebar 1.2) In circulation home page check the effect of IndependentBranchesTransfers on "Transfer" link 1.3) Go to return page and check then effect of IndependentBranchesTransfers on "Transfer" link 2) 2.1) In circ/branchtransfers.pl, with and without IndependentBranches you see all libraries are in combobox 3) 3.1) Set IndependentBranchesTransfers to no and go to circ/branchtransfers.pl 3.2) You are redirected to page 403 unless you are superlibarian Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 88661 [details] [review] Bug 10300: Allow transferring of items to be have separate IndependentBranches syspref Some libraries want to have IndependentBranches enabled, but still be able to transfer items between themselves. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndpendentBranches and IndependentBranchesTransfers 4) Log in as a super librarian 5) Note you can transfer items 6) Log in as a non-super librarian 7) Note you cannot transfer items 8) Disable IndependentBranchesTransfers 9) Note you can now transfer items Signed-off-by: Maribeth Shafer <mshafer@ckls.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 88662 [details] [review] Bug 10300: (follow-up) add controls on transfers page This patch moves the check of IndependentBranchesTransfers pref to templates and adds permission test inside branchtransfers.pl. It also corrects the libraries combobox in branchtransfers.tt, this list can contain all libraries, it is the access to the page that may be protected. Additions to test plan : 1) 1.1) Enable CircSidebar 1.2) In circulation home page check the effect of IndependentBranchesTransfers on "Transfer" link 1.3) Go to return page and check then effect of IndependentBranchesTransfers on "Transfer" link 2) 2.1) In circ/branchtransfers.pl, with and without IndependentBranches you see all libraries are in combobox 3) 3.1) Set IndependentBranchesTransfers to no and go to circ/branchtransfers.pl 3.2) You are redirected to page 403 unless you are superlibarian Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 88663 [details] [review] Bug 10300: (QA follow-up) Make database update idempotent Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Enhancement will not be backported at this time. *** Bug 8450 has been marked as a duplicate of this bug. *** |