Summary: | branch filter not working in serial claims | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Serials | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | colin.campbell, dcook, gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10914 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed patch
[SIGNED OFF [SIGNED OFF] Bug 10429 - branch filter not working in serial claims screenshot of wrong result list [PASSED QA] Bug 10429 - branch filter not working in serial claims |
Description
Fridolin Somers
2013-06-07 12:53:46 UTC
Created attachment 18745 [details] [review] Proposed patch See commit message Created attachment 19747 [details] [review] [SIGNED OFF Created attachment 19748 [details] [review] [SIGNED OFF] Bug 10429 - branch filter not working in serial claims Patch works pretty much as described. Makes the branch filter look nicer and uses the branch names rather than codes. It's worth mentioning that the branch code is still used in the DataTables in "serials-collection.pl". I've opened the follow Bug 10609 in regards to that. (P.S. This patch replaces the one I goofed by accidentally hitting Enter. I miss git bz...) Created attachment 19839 [details]
screenshot of wrong result list
Dependig on the sequence in which you change select the filters it's still possible that the result list does not match the selected filters.
Could you take another look please?
Here is my step by step for the result shown on the screenshot:
1) Open claims page
2) Select "Demo Library"
- filters work correctly, 1 result is shown
3) Switch status to "Expected"
- 2 results are shown, including the one from Centerville
(In reply to Katrin Fischer from comment #4) > Dependig on the sequence in which you change select the filters it's still > possible that the result list does not match the selected filters. > Indeed, the filters are not cumulative. But i think this is another bug. Maybe claims page needs a JQuery datatable. (In reply to Fridolyn SOMERS from comment #5) > Indeed, the filters are not cumulative. But i think this is another bug. > Maybe claims page needs a JQuery datatable. Created Bug 10914 I set back to signedoff For information: I removed these filters in one of my patches for bug 10855 (patch "Bug 10855: Search subscriptions by additional fields on the claim page"). Created attachment 23864 [details] [review] [PASSED QA] Bug 10429 - branch filter not working in serial claims In serial claims page, the branch code is displayed in table instead of branch name and branch filter does not work. This patch adds the display of branch name by using branches template plugin. It changes javascript branch filter to make it work. Also sets "all" filter in template (like status filter) to allow translation and sets "all" as selected by default. Librairian branch was selected by default, but the table was not filtered with it. Test plan : - Go to serials claim of a vendor with serials of multiple branches => You see branch filter with "(All)" and table shows libraries names - Check that branch filter does its work Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Table now shows the branch name instead of the branchcode. First option was named (All), matching the status pull down. When opening the claims page, (All) is preselected and the result list matches with the selection. Before the patch the library was preselected, but the result list did show late issues from all branches. This patch is an improvement, but there is still more work to do. - Filters are not cumulative, but when another filter is selected the first filter is not reset. - It's not possible to combine 2 or more filters. > This patch is an improvement, but there is still more work to do. > > - Filters are not cumulative, but when another filter is selected > the first filter is not reset. > - It's not possible to combine > 2 or more filters. Will be possible with bug 10855 Pushed to master. Thanks, Fridolin! Patch pushed to 3.14.x, will be in 3.14.4. |