Currently, the branch code is being used in the DataTables of serials-collection.pl. Bug 10429 fixed this in claims.pl, so I'm sure a similar method could be used to correct that here as well.
Created attachment 19803 [details] [review] Bug 10609 - Use branch name rather than branch code in serials-collection.pl The serials collection page displays branchcode instead of library name. This patch uses the Branches template plugin to display the library name instead. Also corrected: Added missing datatables config include to prevent a JavaScript error. To test, view the serials collection page for a subsciption with existing issues. Library names should be displayed instead of branchcodes. There should be no JavaScript errors reported by the browser.
Created attachment 19966 [details] [review] Bug 10609 - Use branch name rather than branch code in serials-collection.pl The serials collection page displays branchcode instead of library name. This patch uses the Branches template plugin to display the library name instead. Also corrected: Added missing datatables config include to prevent a JavaScript error. To test, view the serials collection page for a subsciption with existing issues. Library names should be displayed instead of branchcodes. There should be no JavaScript errors reported by the browser. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 20023 [details] [review] [PASSED QA] Bug 10609 - Use branch name rather than branch code in serials-collection.pl The serials collection page displays branchcode instead of library name. This patch uses the Branches template plugin to display the library name instead. Also corrected: Added missing datatables config include to prevent a JavaScript error. To test, view the serials collection page for a subsciption with existing issues. Library names should be displayed instead of branchcodes. There should be no JavaScript errors reported by the browser. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works well and uses the new TT plugin for displaying the branch name.
Pushed to master. Thanks, Owen!
If this fix is needed in 3.12.x a new patch is needed.
Created attachment 20707 [details] [review] Bug 10609: Use branch name rather than branch code in serials-collection.pl (3.12.x) This is the 3.12.x compatible version of the patch for 10609. Regards To+ Sponsored-by: Universidad Nacional de Cordoba
Applying: Bug 10609: Use branch name rather than branch code in serials-collection.pl (3.12.x) Using index info to reconstruct a base tree... M C4/Serials.pm M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Auto-merging C4/Serials.pm Patch failed at 0001 Bug 10609: Use branch name rather than branch code in serials-collection.pl (3.12.x) The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Created attachment 21580 [details] [review] Bug 10609: Use branch name rather than branch code in serials-collection.pl (3.12.x) This is the 3.12.x compatible version of the patch for 10609. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 21837 [details] [review] [PASSED QA] Bug 10609: Use branch name rather than branch code in serials-collection.pl (3.12.x) This is the 3.12.x compatible version of the patch for 10609. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Serial collection page now displays the branch description instead of the branchcode.
This patch has been pushed to 3.12.x, will be in 3.12.6.
Pushed to 3.10.x, will be in 3.10.12