Bug 10677

Summary: C4::Search::GetSearchHistory is broken and unused
Product: Koha Reporter: Galen Charlton <gmcharlt>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jonathan.druart
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 10807    
Bug Blocks:    

Description Galen Charlton 2013-08-02 16:19:27 UTC
C4::Search::GetSearchHistory does not work, as it contains a SQL syntax error:

SELECT FROM search_history WHERE...

Its broken state is not visible to users, however, because that routine is not used -- opac-search-history.pl is doing a direct SQL query, which is not ideal.

GetSearchHistory should be fixed, then put in use.
Comment 1 Jonathan Druart 2014-01-16 11:56:52 UTC
Note that I remove this routine in bug 10807.
Comment 2 Galen Charlton 2014-05-05 02:59:50 UTC
I confirm that the routine was removed.