Bug 10677 - C4::Search::GetSearchHistory is broken and unused
Summary: C4::Search::GetSearchHistory is broken and unused
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 10807
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-02 16:19 UTC by Galen Charlton
Modified: 2014-12-07 20:02 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2013-08-02 16:19:27 UTC
C4::Search::GetSearchHistory does not work, as it contains a SQL syntax error:

SELECT FROM search_history WHERE...

Its broken state is not visible to users, however, because that routine is not used -- opac-search-history.pl is doing a direct SQL query, which is not ideal.

GetSearchHistory should be fixed, then put in use.
Comment 1 Jonathan Druart 2014-01-16 11:56:52 UTC
Note that I remove this routine in bug 10807.
Comment 2 Galen Charlton 2014-05-05 02:59:50 UTC
I confirm that the routine was removed.