Description
Olli-Antti Kivilahti
2013-10-09 15:43:11 UTC
Created attachment 22002 [details] [review] Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. Depends on bug 11005 Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm Includes unit tests. Created attachment 22324 [details] [review] Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. Depends on bug 11005 Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm Includes unit tests. Fixed tabs to spaces in indentation. Created attachment 22692 [details] [review] Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. Depends on bug 11005 Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm Includes unit tests. Created attachment 22694 [details] [review] Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. Depends on bug 11005 Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm Includes unit tests. Created attachment 23166 [details] [review] Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. Depends on bug 11005 Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm Includes unit tests. Formatted using perltidy and Perl::Critic You've done a lot of perltidy-ing. Can you please split the actual code changes into a separate patch from the tidied code? Thanks! Sorry I cannot focus at this atm. Quite frankly I am just now starting to recall this feature. We don't use it atm. There is a big design problem here: What happens if the queued Item is Lost (and we don't know that it is lost)? Does the Borrower waiting for the Lost Item have to wait forever, since the feature always gives the same Items on each iteration regardless of how long the Borrower has laready been waiting for his Item? I have a good idea (on my opinion) on how to solve this issue, if you want to tackle it, let me know! What is the current status of this bug? - It blocks a bug marked as critical: Bug 7376 Moving to new bug that encompasses multiple old bugs. *** This bug has been marked as a duplicate of bug 22330 *** |