Bug 11024

Summary: Transfer limits should be respected in the build_holds_queue.pl -script.
Product: Koha Reporter: Olli-Antti Kivilahti <olli-antti.kivilahti>
Component: Hold requestsAssignee: Olli-Antti Kivilahti <olli-antti.kivilahti>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P3 CC: gmcharlt, jonathan.druart, kyle, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 11020    
Bug Blocks: 7376    
Attachments: Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script.
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script.
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script.
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script.
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script.

Description Olli-Antti Kivilahti 2013-10-09 15:43:11 UTC
No point in having fancy transfer limits if they cannot be targeted properly to respect the transfer limits.

Modify the holds targeter to respect transfer limits.
Comment 1 Olli-Antti Kivilahti 2013-10-15 10:48:39 UTC Comment hidden (obsolete)
Comment 2 Olli-Antti Kivilahti 2013-10-23 15:14:43 UTC Comment hidden (obsolete)
Comment 3 Olli-Antti Kivilahti 2013-10-23 15:22:24 UTC
Fixed tabs to spaces in indentation.
Comment 4 Olli-Antti Kivilahti 2013-11-04 11:33:28 UTC Comment hidden (obsolete)
Comment 5 Olli-Antti Kivilahti 2013-11-04 11:35:21 UTC Comment hidden (obsolete)
Comment 6 Olli-Antti Kivilahti 2013-11-26 16:52:20 UTC
Created attachment 23166 [details] [review]
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script.

Depends on bug 11005

Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm

Includes unit tests.

Formatted using perltidy and Perl::Critic
Comment 7 Kyle M Hall 2015-07-24 15:39:12 UTC
You've done a lot of perltidy-ing. Can you please split the actual code changes into a separate patch from the tidied code?

Thanks!
Comment 8 Olli-Antti Kivilahti 2015-07-27 09:06:25 UTC
Sorry I cannot focus at this atm.
Comment 9 Olli-Antti Kivilahti 2015-07-27 09:11:37 UTC
Quite frankly I am just now starting to recall this feature.
We don't use it atm.
There is a big design problem here:
    What happens if the queued Item is Lost (and we don't know that it is lost)?
    Does the Borrower waiting for the Lost Item have to wait forever, since the feature always gives the same Items on each iteration regardless of how long the Borrower has laready been waiting for his Item?
I have a good idea (on my opinion) on how to solve this issue, if you want to tackle it, let me know!
Comment 10 Marc VĂ©ron 2015-12-24 13:20:08 UTC
What is the current status of this bug? - It blocks a bug marked as critical: Bug 7376
Comment 11 Kyle M Hall 2019-02-13 20:36:14 UTC
Moving to new bug that encompasses multiple old bugs.

*** This bug has been marked as a duplicate of bug 22330 ***