Bug 11020 - Transfer limits should be checked when placing a hold/reservation in Staff client
Summary: Transfer limits should be checked when placing a hold/reservation in Staff cl...
Status: RESOLVED DUPLICATE of bug 22330
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P3 enhancement (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
Depends on: 10993
Blocks: 11024
  Show dependency treegraph
 
Reported: 2013-10-09 10:34 UTC by Olli-Antti Kivilahti
Modified: 2019-02-13 20:35 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11020 [ENH] - Transfer limits should be checked when placing a hold/reservation in Staff client (20.02 KB, patch)
2013-10-09 15:40 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
manual test cases (2.60 KB, text/plain)
2013-10-09 15:41 UTC, Olli-Antti Kivilahti
Details
Manual test cases (2.60 KB, text/plain)
2013-10-15 10:22 UTC, Olli-Antti Kivilahti
Details
Bug 11020 - Transfer limits should be checked when placing a hold/reservation in Staff client (19.84 KB, patch)
2013-10-15 10:23 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 11020 - Transfer limits should be checked when placing a hold/reservation in Staff client (23.44 KB, patch)
2013-10-23 15:13 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 11020 - Transfer limits should be checked when placing a hold/reservation in Staff client (63.33 KB, patch)
2013-11-26 16:48 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2013-10-09 10:34:23 UTC
Extending bug 10993, 11005 to the staff client.
Comment 1 Olli-Antti Kivilahti 2013-10-09 15:40:57 UTC Comment hidden (obsolete)
Comment 2 Olli-Antti Kivilahti 2013-10-09 15:41:18 UTC Comment hidden (obsolete)
Comment 3 Olli-Antti Kivilahti 2013-10-09 15:51:04 UTC
Sponsored by the Joensuu Regional Library
Comment 4 Olli-Antti Kivilahti 2013-10-15 10:22:41 UTC
Created attachment 21997 [details]
Manual test cases
Comment 5 Olli-Antti Kivilahti 2013-10-15 10:23:22 UTC Comment hidden (obsolete)
Comment 6 Paul Poulain 2013-10-23 00:00:38 UTC
QA comments: none, except the 4 spaces/tabs one.

Just in case, you could/should read : http://wiki.koha-community.org/wiki/Coding_Guidelines
Comment 7 Olli-Antti Kivilahti 2013-10-23 15:13:15 UTC Comment hidden (obsolete)
Comment 8 Olli-Antti Kivilahti 2013-10-23 15:25:00 UTC
Fixed tabs to spaces in indentation. Didn't realize my IDE uses tabs instead of spaces until bug 11024/7376.
Comment 9 Olli-Antti Kivilahti 2013-11-26 16:48:18 UTC
Created attachment 23165 [details] [review]
Bug 11020 - Transfer limits should be checked when placing a hold/reservation in Staff client

Extended bug 11005.

Extended C4/Reserves.pm to support checking BranchTransferLimits when requested. Extension does
in no way disturb existing functionality.

Modified the templates to show branch transfer blocks to the user.
Modified the business layer to re-check branch transfer limits in case user fools the POST-request.

Created manual test plans.

Formatted using perltidy and Perl::Critic
Comment 10 Mark Tompsett 2015-05-15 05:39:27 UTC
Is this still a problem?
Comment 11 Kyle M Hall 2019-02-13 20:35:51 UTC
Moving to new bug that encompasses multiple old bugs.

*** This bug has been marked as a duplicate of bug 22330 ***