Description
Jonathan Druart
2013-10-22 12:07:08 UTC
Created attachment 22266 [details] [review] Bug 11111: The basket group is not display on the parcel page Test plan: Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name is displayed into the 2nd column. Created attachment 22287 [details] [review] [SIGN-OFF]Bug 11111: The basket group is not display on the parcel page Test plan: Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name is displayed into the 2nd column. Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Created attachment 22435 [details] [review] [PASSED QA] Bug 11111: The basket group is not display on the parcel page Test plan: Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name is displayed into the 2nd column. Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changed basketgroup to basket group to match spelling on other pages. Works as described, passes tests and QA script. Patch no longer applies, and this close to string freeze I don't want to risk messing up the merge conflict resolution. Also, since this patch touches SearchOrders(), a unit test should be added. Created attachment 22680 [details] [review] Bug 11111: The basket group is not display on the parcel page Test plan: Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name is displayed into the 2nd column. Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changed basketgroup to basket group to match spelling on other pages. Works as described, passes tests and QA script. Created attachment 22681 [details] [review] Bug 11111: UT: SearchOrders returns keys basketgroupid and basketgroupname Created attachment 22682 [details] [review] Bug 11111: The basket group is not display on the parcel page Test plan: Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name is displayed into the 2nd column. Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changed basketgroup to basket group to match spelling on other pages. Works as described, passes tests and QA script. Created attachment 22683 [details] [review] Bug 11111: UT: SearchOrders returns keys basketgroupid and basketgroupname Pushed to master, along with a follow-up correcting column sorting. Thanks, Jonathan! Those patches have been pushed to 3.14.x, will be in 3.14.1 |