Bug 10724 - Search by basket group on the parcel page
Summary: Search by basket group on the parcel page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL: acqui/parcel.pl
Keywords:
Depends on: 10723
Blocks: 10124 10725
  Show dependency treegraph
 
Reported: 2013-08-14 08:54 UTC by Jonathan Druart
Modified: 2014-05-26 21:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10724: Pending orders: add basket group name in filters (6.73 KB, patch)
2013-08-14 09:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 10724: Pending orders: add basket group name in filters (6.76 KB, patch)
2013-09-22 12:16 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-08-14 08:54:23 UTC

    
Comment 1 Jonathan Druart 2013-08-14 09:00:04 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2013-09-22 11:22:16 UTC
Looking at this now.
Comment 3 Katrin Fischer 2013-09-22 12:15:21 UTC
Hi Jonathan, this works as described. I think it would be a nice addition, if the basket group name was visible in the table of pending orders - it's a bit hard to see if you got correct results right now :)
Comment 4 Katrin Fischer 2013-09-22 12:16:38 UTC
Created attachment 21311 [details] [review]
[PASSED QA] Bug 10724: Pending orders: add basket group name in filters

This patch adds a new filter "basket group name" for pending orders
searches.

Test plan:
Try different filters and check that results are consistent.
Try to filter by basket group name.

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Applied on top of patches for bug 10723.
Passes all tests and QA script.
Tested combining different search options and checking
results for correctness.

Note: It's a bit irritating that the basket name is not shown
in the list of pending orders, so there is no way to check the
results are correct without checking from another page.

Also, with a lot of pending orders in the system this page
is very slow - I think it's a candidate for server side processing.
Comment 5 Galen Charlton 2013-10-21 19:05:05 UTC
Pushed to master.  Thanks, Jonathan!

I agree with Katrin that the pending orders list should display the basket group name.
Comment 6 Mathieu Saby 2013-10-22 08:10:05 UTC
(In reply to Galen Charlton from comment #5)
> Pushed to master.  Thanks, Jonathan!
> 
> I agree with Katrin that the pending orders list should display the basket
> group name.

For me, that's simple : You need to use BG to make pdf, so for some (most?) libraries, the main "entity" for dealing orders is BG, not Basket.
(1 BG => pdf/csv send to the vendor => matches 1 or several vendor invoices etc)
It was very important for us to have the ability to search by BG number/name. 
We made a local patch in JS/PHP in my library for that.

So, BG number AND BG name should be displayed and searchable in every place where basket number and basket name are.

See Bug 11027, Bug 9560, Bug 7682, Bug 9561, Bug 9808.
And when Bug 9807 is pushed, we will be able to made direct links to individual BG (not possible now, because it reopens the BG).

Mathieu
Comment 7 Jonathan Druart 2013-10-22 12:10:16 UTC
(In reply to Galen Charlton from comment #5)
> Pushed to master.  Thanks, Jonathan!
> 
> I agree with Katrin that the pending orders list should display the basket
> group name.

Galen, I submitted a patch on bug 11111.