Created attachment 20326 [details] [review] Bug 10724: Pending orders: add basket group name in filters This patch adds a new filter "basket group name" for pending orders searches. Test plan: Try different filters and check that results are consistent. Try to filter by basket group name. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Looking at this now.
Hi Jonathan, this works as described. I think it would be a nice addition, if the basket group name was visible in the table of pending orders - it's a bit hard to see if you got correct results right now :)
Created attachment 21311 [details] [review] [PASSED QA] Bug 10724: Pending orders: add basket group name in filters This patch adds a new filter "basket group name" for pending orders searches. Test plan: Try different filters and check that results are consistent. Try to filter by basket group name. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Applied on top of patches for bug 10723. Passes all tests and QA script. Tested combining different search options and checking results for correctness. Note: It's a bit irritating that the basket name is not shown in the list of pending orders, so there is no way to check the results are correct without checking from another page. Also, with a lot of pending orders in the system this page is very slow - I think it's a candidate for server side processing.
Pushed to master. Thanks, Jonathan! I agree with Katrin that the pending orders list should display the basket group name.
(In reply to Galen Charlton from comment #5) > Pushed to master. Thanks, Jonathan! > > I agree with Katrin that the pending orders list should display the basket > group name. For me, that's simple : You need to use BG to make pdf, so for some (most?) libraries, the main "entity" for dealing orders is BG, not Basket. (1 BG => pdf/csv send to the vendor => matches 1 or several vendor invoices etc) It was very important for us to have the ability to search by BG number/name. We made a local patch in JS/PHP in my library for that. So, BG number AND BG name should be displayed and searchable in every place where basket number and basket name are. See Bug 11027, Bug 9560, Bug 7682, Bug 9561, Bug 9808. And when Bug 9807 is pushed, we will be able to made direct links to individual BG (not possible now, because it reopens the BG). Mathieu
(In reply to Galen Charlton from comment #5) > Pushed to master. Thanks, Jonathan! > > I agree with Katrin that the pending orders list should display the basket > group name. Galen, I submitted a patch on bug 11111.