Summary: | JavaScript error on staff client biblio details pages if template variables are undefined | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, gwilliams, jesse, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Medium patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 9780, 9823 | ||
Bug Blocks: | 11836, 11821 | ||
Attachments: |
Bug 11829 - JavaScript error on staff client biblio details pages if template variables are undefined
[Signed-off] Bug 11829 - JavaScript error on staff client biblio details pages if template variables are undefined [PASSED QA] Bug 11829 - JavaScript error on staff client biblio details pages if template variables are undefined |
Description
Owen Leonard
2014-02-24 15:18:47 UTC
Looks like this was caused by the QA follow-up to 9823 Created attachment 25588 [details] [review] Bug 11829 - JavaScript error on staff client biblio details pages if template variables are undefined The JavaScript included in cat-toolbar.inc expects several variables to be passed to the template for use in calculations. Several scripts to not pass the required variables to the template, leading to a JS error. This patch re-adds (See Bug 9823) hold count calculation to the required scripts and copies the acquisitions-related count calculation from detail.pl into related bibliographic detail scripts so that the commonnly-included cat-toolbar.inc can receive correct values. To test, locate a bibliographic record which has no holds and is not used in a current or deleted order, but which has a local cover image attached. Check the following views to confirm there is no JavaScript error: - Normal - MARC - Labeled MARC - ISBD - Items - Images (from the Images tab on the "Normal" detail page) Next, locate a bibliographic record with no items attached which is used in an Acquisitions order. On each of the pages listed above, choose "Delete record" from the Edit menu. This should trigger a warning that the record is used in an order. Cancel the deletion. Finally, delete the order which references the bibliographic record. On each of the pages listed above, choose "Delete record" again. This should trigger a warning that the record is used in a deleted order. Cancel the deletion. *** Bug 11831 has been marked as a duplicate of this bug. *** Created attachment 25593 [details] [review] [Signed-off] Bug 11829 - JavaScript error on staff client biblio details pages if template variables are undefined The JavaScript included in cat-toolbar.inc expects several variables to be passed to the template for use in calculations. Several scripts to not pass the required variables to the template, leading to a JS error. This patch re-adds (See Bug 9823) hold count calculation to the required scripts and copies the acquisitions-related count calculation from detail.pl into related bibliographic detail scripts so that the commonnly-included cat-toolbar.inc can receive correct values. To test, locate a bibliographic record which has no holds and is not used in a current or deleted order, but which has a local cover image attached. Check the following views to confirm there is no JavaScript error: - Normal - MARC - Labeled MARC - ISBD - Items - Images (from the Images tab on the "Normal" detail page) Next, locate a bibliographic record with no items attached which is used in an Acquisitions order. On each of the pages listed above, choose "Delete record" from the Edit menu. This should trigger a warning that the record is used in an order. Cancel the deletion. Finally, delete the order which references the bibliographic record. On each of the pages listed above, choose "Delete record" again. This should trigger a warning that the record is used in a deleted order. Cancel the deletion. I went through the test plan, everything works OK. It resolves Bug 11831 as well. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 25604 [details] [review] [PASSED QA] Bug 11829 - JavaScript error on staff client biblio details pages if template variables are undefined The JavaScript included in cat-toolbar.inc expects several variables to be passed to the template for use in calculations. Several scripts to not pass the required variables to the template, leading to a JS error. This patch re-adds (See Bug 9823) hold count calculation to the required scripts and copies the acquisitions-related count calculation from detail.pl into related bibliographic detail scripts so that the commonnly-included cat-toolbar.inc can receive correct values. To test, locate a bibliographic record which has no holds and is not used in a current or deleted order, but which has a local cover image attached. Check the following views to confirm there is no JavaScript error: - Normal - MARC - Labeled MARC - ISBD - Items - Images (from the Images tab on the "Normal" detail page) Next, locate a bibliographic record with no items attached which is used in an Acquisitions order. On each of the pages listed above, choose "Delete record" from the Edit menu. This should trigger a warning that the record is used in an order. Cancel the deletion. Finally, delete the order which references the bibliographic record. On each of the pages listed above, choose "Delete record" again. This should trigger a warning that the record is used in a deleted order. Cancel the deletion. I went through the test plan, everything works OK. It resolves Bug 11831 as well. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - Printing from MARC and ISBD view works again - No more Javascript errors found - Deleting a record with attached order gives the correct warning, both for ordered and cancelled. Passes all tests and QA script. Pushed to master. Thanks, Owen! I've opened bug 11836 for the code duplication (re)introduced by this patch. *** Bug 11841 has been marked as a duplicate of this bug. *** This patch corrects also the feature added by bug 9780. Pushed to 3.14.x, will be in 3.14.07 (Quite a dirty bug) |