Bug 11836 - population of template variables used by cat-toolbar.inc should be centralized
Summary: population of template variables used by cat-toolbar.inc should be centralized
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on: 11829
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-25 16:59 UTC by Galen Charlton
Modified: 2018-01-09 15:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2014-02-25 16:59:44 UTC
There are a variety of pages that display bib details and the like that use the cataloging toolbar:

catalogue/detail.pl
catalogue/MARCdetail.pl
catalogue/labeledMARCdetail.pl
catalogue/ISBDdetail.pl
catalogue/moredetail.pl
catalogue/imageviewer.pl

In order to reduce the risk of bugs like bug 11829 and to eliminate error-prone code duplication, the population of variables required by the cataloging toolbar should be centralized.  A couple options include:

- a central routine in the Koha namespace (Koha::Template::Toolbars::Cataloguing?)
- a template block that uses template plugins to fetch the required information

I'm leaning towards the latter so long as the performance penalty of potential repeated fetches in the database isn't too high.
Comment 1 Galen Charlton 2014-02-25 17:08:54 UTC
Some feedback on IRC:

<gmcharlt> I would appreciate feedback on bug 11836, as I see a couple different directions for centralizing the cataloging toolbar management code
<huginn`> Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11836 enhancement, P5 - low, ---, gmcharlt, NEW , population of template variables used by cat-toolbar.inc should be centralized
<wajasu> i'd go with the later option, since its presentation specfic.  But if you want a test written, the class you mentioned might be easier to write one for.
<gmcharlt> bug 11837 is similar
<huginn`> Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11837 enhancement, P5 - low, ---, gmcharlt, NEW , generation of template-variables used by members-toolbar.inc should be centralized
<wajasu> i have the same problem trying to schedule.  let me look at the code.
<gmcharlt> wajasu: actually, I don't think it's any harder to write test cases for template plugins
<gmcharlt> e.g., t/db_dependent/Koha_template_plugin_Branches.t
<wajasu> ok.  a plugin.